[libvirt] [PATCH] maint: enforce recent N_ usage
* cfg.mk (sc_prohibit_gettext_noop): New rule. --- cfg.mk | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3fd9f7b..5b4d6ed 100644 --- a/cfg.mk +++ b/cfg.mk @@ -105,6 +105,11 @@ sc_prohibit_gethostname: msg='use virGetHostname, not gethostname' \ $(_prohibit_regexp) +sc_prohibit_gettext_noop: + @re='gettext_noop *\(' \ + msg='use _N, not gettext_noop' \ + $(_prohibit_regexp) + sc_prohibit_VIR_ERR_NO_MEMORY: @re='\<V''IR_ERR_NO_MEMORY\>' \ msg='use virReportOOMError, not V'IR_ERR_NO_MEMORY \ -- 1.6.6.1
On Wed, Mar 17, 2010 at 05:22:03PM -0600, Eric Blake wrote:
* cfg.mk (sc_prohibit_gettext_noop): New rule. --- cfg.mk | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/cfg.mk b/cfg.mk index 3fd9f7b..5b4d6ed 100644 --- a/cfg.mk +++ b/cfg.mk @@ -105,6 +105,11 @@ sc_prohibit_gethostname: msg='use virGetHostname, not gethostname' \ $(_prohibit_regexp)
+sc_prohibit_gettext_noop: + @re='gettext_noop *\(' \ + msg='use _N, not gettext_noop' \ + $(_prohibit_regexp) + sc_prohibit_VIR_ERR_NO_MEMORY: @re='\<V''IR_ERR_NO_MEMORY\>' \ msg='use virReportOOMError, not V'IR_ERR_NO_MEMORY \
ACK, pushed, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
--- Phooey - I didn't notice my typo until too late. Would you mind pushing this trivial followup? cfg.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index 5b4d6ed..9fc2d66 100644 --- a/cfg.mk +++ b/cfg.mk @@ -107,7 +107,7 @@ sc_prohibit_gethostname: sc_prohibit_gettext_noop: @re='gettext_noop *\(' \ - msg='use _N, not gettext_noop' \ + msg='use N_, not gettext_noop' \ $(_prohibit_regexp) sc_prohibit_VIR_ERR_NO_MEMORY: -- 1.6.6.1
participants (2)
-
Daniel Veillard -
Eric Blake