On 06/26/2012 05:37 AM, Daniel Veillard wrote:
On Fri, Mar 09, 2012 at 04:12:46PM +0100, Wido den Hollander wrote:
>
> Signed-off-by: Wido den Hollander <wido(a)widodh.nl>
> ---
> src/main/java/org/libvirt/Secret.java | 11 +++++++++++
> src/main/java/org/libvirt/jna/Libvirt.java | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/src/main/java/org/libvirt/Secret.java
b/src/main/java/org/libvirt/Secret.java
> index e536cf4..48f7895 100644
> --- a/src/main/java/org/libvirt/Secret.java
> +++ b/src/main/java/org/libvirt/Secret.java
> @@ -146,6 +146,17 @@ public class Secret {
> }
>
> /**
> + * Sets the value of the secret
> + *
> + * @return 0 on success, -1 on failure.
> + */
> + public int setValue(byte[] value) throws LibvirtException {
> + int returnValue = libvirt.virSecretSetValue(VSP, value, new
NativeLong(value.length), 0);
> + processError();
> + return returnValue;
> + }
> +
> + /**
> * Undefines, but does not free, the Secret.
> *
> * @return 0 on success, -1 on failure.
> diff --git a/src/main/java/org/libvirt/jna/Libvirt.java
b/src/main/java/org/libvirt/jna/Libvirt.java
> index 2c8c03d..b1e53a2 100644
> --- a/src/main/java/org/libvirt/jna/Libvirt.java
> +++ b/src/main/java/org/libvirt/jna/Libvirt.java
> @@ -336,6 +336,7 @@ public interface Libvirt extends Library {
> public SecretPointer virSecretLookupByUUID(ConnectionPointer virConnectPtr,
byte[] uuidBytes);
> public SecretPointer virSecretLookupByUUIDString(ConnectionPointer
virConnectPtr, String uuidstr);
> public int virSecretSetValue(SecretPointer virSecretPtr, String value,
NativeLong value_size, int flags);
> + public int virSecretSetValue(SecretPointer virSecretPtr, byte[] value,
NativeLong value_size, int flags);
> public int virSecretUndefine(SecretPointer virSecretPtr);
>
> //Stream Methods
Patch looks fine, pushed, thanks !
BTW will you come up with a second version of the patch for
secretGetValue as Eric suggested ? Or I didn't see it :-)
Oh, totally forgot! I wrote it, but never submitted it :-)
I'll re-submit it asap!
Wido
thanks !
Daniel