3:36 a.m.
This patch just cleans up the virStorageDriver structs so that they use the
.functionPointer = functionname syntax of gcc. This makes it much easier to
grep in the code later. This patch also re-arranges the order of the function
pointers in remote_internal so that it matches the definition of
virStorageDriver in src/driver.h. While not strictly necessary, it does make it
a little more sane when looking at it in the future.
Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
4:23 a.m.
On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
This patch just cleans up the virStorageDriver structs so that they
use the
functionPointer = functionname syntax of gcc. This makes it much easier to
grep in the code later. This patch also re-arranges the order of the function
pointers in remote_internal so that it matches the definition of
virStorageDriver in src/driver.h. While not strictly necessary, it does make it
a little more sane when looking at it in the future.
Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
5:16 a.m.
On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
This patch just cleans up the virStorageDriver structs so that they
use the
functionPointer = functionname syntax of gcc. This makes it much easier to
+1.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
2:53 p.m.
On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
This patch just cleans up the virStorageDriver structs so that they
use the
functionPointer = functionname syntax of gcc. This makes it much easier to
grep in the code later. This patch also re-arranges the order of the function
pointers in remote_internal so that it matches the definition of
virStorageDriver in src/driver.h. While not strictly necessary, it does make it
a little more sane when looking at it in the future.
Okidoc, uncontroversial, so applied and commited,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
12:34 a.m.
Daniel Veillard wrote:
On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
> This patch just cleans up the virStorageDriver structs so that they use the
> functionPointer = functionname syntax of gcc. This makes it much easier to
> grep in the code later. This patch also re-arranges the order of the function
> pointers in remote_internal so that it matches the definition of
> virStorageDriver in src/driver.h. While not strictly necessary, it does make it
> a little more sane when looking at it in the future.
Okidoc, uncontroversial, so applied and commited,
thanks !
Thanks for committing DV. I still have to work on answering danpb's one other
question on patch 3 (hopefully today), and then I'll post answers/updated patch
for that one.
Chris Lalancette
2:43 a.m.
On Tue, Sep 23, 2008 at 07:34:17AM +0200, Chris Lalancette wrote:
Daniel Veillard wrote:
> On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
>> This patch just cleans up the virStorageDriver structs so that they use the
>> functionPointer = functionname syntax of gcc. This makes it much easier to
>> grep in the code later. This patch also re-arranges the order of the function
>> pointers in remote_internal so that it matches the definition of
>> virStorageDriver in src/driver.h. While not strictly necessary, it does make
it
>> a little more sane when looking at it in the future.
>
> Okidoc, uncontroversial, so applied and commited,
>
> thanks !
Thanks for committing DV. I still have to work on answering danpb's one other
question on patch 3 (hopefully today), and then I'll post answers/updated patch
for that one.
Yup, note that I commited patch 3 too, the controversial point is
trivial to revert, and assuming we need different handling for pre F-9
and post F-9 having a separate patch about the issue is probably nicer
too.
Still I'm surprized ad the -f force option seems present on my lvm2
version on RHEL5:
test:~ -> vgremove --help 2>/dev/null | grep force
[-f|--force]
test:~ -> rpm -qif `which vgremove`
Name : lvm2 Relocations: (not
relocatable)
Version : 2.02.32 Vendor: Red Hat, Inc.
Release : 4.el5 Build Date: Fri 04 Apr 2008
01:15:19 PM CEST
Install Date: Thu 12 Jun 2008 03:15:52 PM CEST Build Host:
hs20-bc2-3.build.redhat.com
the rpm was built recently, and apparently the update to upstream was
done around January
* Thu Jan 17 2008 Milan Broz <mbroz(a)redhat.com> - 2.02.30-1
- Update to latest upstream release.
Are you sure the -f option is really the problem you're seing ?
Maybe I'm just confused, which is quite possible too :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
5905
days inactive
5909
days old
5 comments
4 participants
participants (4)
-
Chris Lalancette -
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones