Despite running all subtests successfully, hooks/051-daemon-hook.t ends with a return code of 141. This is due to the connection to tck not being cleaned up properly after libvirtd is restarted in the middle of the test. Ignoring the SIGPIPE and specifically undefining $tck allows the test to complete with a return code of 0 (which is helpful when running the full libvirt-tck kit). --- scripts/hooks/051-daemon-hook.t | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/hooks/051-daemon-hook.t b/scripts/hooks/051-daemon-hook.t index 165cf4e..da46edf 100644 --- a/scripts/hooks/051-daemon-hook.t +++ b/scripts/hooks/051-daemon-hook.t @@ -163,5 +163,9 @@ SKIP: { ok(`service libvirtd status` =~ /running/, "libvirtd is running"); $hook->cleanup(); + + # Restarting libvirtd broke the tck connection, so ignore the sigpipe and remove $tck + $SIG{PIPE} = 'IGNORE'; + undef $tck; }; -- 1.8.4.5

Correct the order of parameters passed to skip to ensure the following tests are only executed under qemu and lxc environments: hooks/051-daemon-hook.t hooks/052-domain-hook.t --- scripts/hooks/051-daemon-hook.t | 2 +- scripts/hooks/052-domain-hook.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/hooks/051-daemon-hook.t b/scripts/hooks/051-daemon-hook.t index da46edf..61909c1 100644 --- a/scripts/hooks/051-daemon-hook.t +++ b/scripts/hooks/051-daemon-hook.t @@ -43,7 +43,7 @@ END { $tck->cleanup if $tck; } SKIP: { my $uri = $conn->get_uri(); - skip 12, "NOT using QEMU/LXC driver" unless + skip "NOT using QEMU/LXC driver", 12 unless $uri eq "qemu:///system" or $uri eq "lxc:///"; my $hook = Sys::Virt::TCK::Hooks->new(type => 'daemon', diff --git a/scripts/hooks/052-domain-hook.t b/scripts/hooks/052-domain-hook.t index 460d72d..cdd70af 100644 --- a/scripts/hooks/052-domain-hook.t +++ b/scripts/hooks/052-domain-hook.t @@ -46,7 +46,7 @@ END { $tck->cleanup if $tck; } SKIP: { my $uri = $conn->get_uri(); - skip 12, "Not using QEMU/LXC driver" unless + skip "NOT using QEMU/LXC driver", 12 unless $uri eq "qemu:///system" or $uri eq "lxc:///"; my $xml = $tck->generic_domain(name => "tck")->as_xml; -- 1.8.4.5

When TCK cleans up a test domain, existing snapshots are deleted. However, not all drivers (e.g. libxl) support snapshots. When such a driver is involved, the following error is reported and the testkit fails to cleanup the domain: libvirt error code: 3, message: this function is not supported by the connection driver: virDomainSnapshotNum Rather than erroring out, list_snapshots should be protected using eval. In the event the underlying driver does not support snapshots, an empty list is returned, and no snapshot deletion is attempted. (Note - It is the listing of snapshots that is causing the error, not the attempt to delete them.) --- lib/Sys/Virt/TCK.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index f8fa75d..a3d06a2 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -145,7 +145,8 @@ sub reset_snapshots { my $self = shift; my $dom = shift; - my @domss = $dom->list_snapshots; + # Use eval as not all drivers support snapshots + my @domss = eval { $dom->list_snapshots }; foreach my $domss (@domss) { $domss->delete; } -- 1.8.4.5