[libvirt] [PATCH] virsh: Add one blank line after output of dompmsuspend/dompmwakeup
There should be include one blank line after result of dompmsuspend and dompmwakeup --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 73414f8..3aca1e7 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2830,7 +2830,7 @@ cmdDomPMSuspend(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - vshPrint(ctl, _("Domain %s successfully suspended"), + vshPrint(ctl, _("Domain %s successfully suspended\n"), virDomainGetName(dom)); ret = true; @@ -2881,7 +2881,7 @@ cmdDomPMWakeup(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - vshPrint(ctl, _("Domain %s successfully woken up"), + vshPrint(ctl, _("Domain %s successfully woken up\n"), virDomainGetName(dom)); ret = true; -- 1.8.3.1
On Fri, Apr 11, 2014 at 21:29:18 +0800, Shanzhi Yu wrote:
There should be include one blank line after result of dompmsuspend and dompmwakeup
Personally, I don't like the recent patches adding useless empty lines at the end of virsh output. I think the empty lines are more bugs than features and they should rather be all removed. However, I'm not sure if that would be considered backwards incompatible or not. But in any case we should not be adding more of them. Jirka
participants (2)
-
Jiri Denemark -
Shanzhi Yu