[libvirt] [PATCH v2] Fix bug with loading bridge name for active domain during libvirtd start

If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- changes in v2: - added error message if bridge name is missing. src/conf/domain_conf.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9cc118c..0a7d0b8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6850,6 +6850,15 @@ virDomainActualNetDefParseXML(xmlNodePtr node, goto error; } VIR_FREE(class_id); + } else if (actual->type == VIR_DOMAIN_NET_TYPE_BRIDGE) { + char *brname = virXPathString("string(./source/@bridge)", ctxt); + if (!brname) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Missing <source> element with bridge name in " + "interface's <actual> element")); + goto error; + } + actual->data.bridge.brname = brname; } bandwidth_node = virXPathNode("./bandwidth", ctxt); -- 1.8.5.5

On 09/24/14 11:36, Pavel Hrdina wrote:
If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> ---
changes in v2: - added error message if bridge name is missing.
src/conf/domain_conf.c | 9 +++++++++ 1 file changed, 9 insertions(+)
ACK

On 09/24/2014 11:45 AM, Peter Krempa wrote:
On 09/24/14 11:36, Pavel Hrdina wrote:
If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> ---
changes in v2: - added error message if bridge name is missing.
src/conf/domain_conf.c | 9 +++++++++ 1 file changed, 9 insertions(+)
ACK
Thanks, pushed. Pavel
participants (2)
-
Pavel Hrdina
-
Peter Krempa