[libvirt] [PATCH 1/2] spec: Use power64 macro
From: Peter Robinson <pbrobinson@fedoraproject.org> Covers the whole ppc64 family. Example bug for binutils: https://bugzilla.redhat.com/show_bug.cgi?id=834651 --- libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 76e57aa..cac7d99 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -60,15 +60,16 @@ %if 0%{?fedora} %if 0%{?fedora} < 16 # Fedora doesn't have any QEMU on ppc64 until FC16 - only ppc + # I think F17 is the first release with the power64 macro %ifarch ppc64 %define with_qemu_tcg 0 %endif %endif %if 0%{?fedora} >= 18 - %define qemu_kvm_arches %{ix86} x86_64 ppc64 s390x + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %endif %if 0%{?fedora} >= 20 - %define qemu_kvm_arches %{ix86} x86_64 ppc64 s390x %{arm} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} %endif %endif -- 1.9.3
From: Peter Robinson <pbrobinson@fedoraproject.org> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index cac7d99..424b6e2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -69,7 +69,7 @@ %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %endif %if 0%{?fedora} >= 20 - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 %endif %endif -- 1.9.3
On 07/18/2014 11:28 AM, Cole Robinson wrote:
From: Peter Robinson <pbrobinson@fedoraproject.org>
--- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/libvirt.spec.in b/libvirt.spec.in index cac7d99..424b6e2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -69,7 +69,7 @@ %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %endif %if 0%{?fedora} >= 20 - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 %endif %endif
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 07/18/2014 04:05 PM, Eric Blake wrote:
On 07/18/2014 11:28 AM, Cole Robinson wrote:
From: Peter Robinson <pbrobinson@fedoraproject.org>
--- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Spoke too soon:
diff --git a/libvirt.spec.in b/libvirt.spec.in index cac7d99..424b6e2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -69,7 +69,7 @@ %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %endif %if 0%{?fedora} >= 20
This says F20, but your subject line says F21. One of the two is wrong. Please fix before committing.
- %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 %endif %endif
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 07/18/2014 06:05 PM, Eric Blake wrote:
On 07/18/2014 04:05 PM, Eric Blake wrote:
On 07/18/2014 11:28 AM, Cole Robinson wrote:
From: Peter Robinson <pbrobinson@fedoraproject.org>
--- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Spoke too soon:
diff --git a/libvirt.spec.in b/libvirt.spec.in index cac7d99..424b6e2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -69,7 +69,7 @@ %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %endif %if 0%{?fedora} >= 20
This says F20, but your subject line says F21. One of the two is wrong. Please fix before committing.
Changelog was wrong, pushed with the fix. Thanks, Cole
- %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 %endif %endif
On 07/18/2014 11:28 AM, Cole Robinson wrote:
From: Peter Robinson <pbrobinson@fedoraproject.org>
Covers the whole ppc64 family. Example bug for binutils:
https://bugzilla.redhat.com/show_bug.cgi?id=834651 --- libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 76e57aa..cac7d99 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -60,15 +60,16 @@ %if 0%{?fedora} %if 0%{?fedora} < 16 # Fedora doesn't have any QEMU on ppc64 until FC16 - only ppc + # I think F17 is the first release with the power64 macro %ifarch ppc64 %define with_qemu_tcg 0 %endif
Of course, we may delete this hunk in a later patch, but it works for now. I did not try to fire up my F16 VM to run 'make dist' - we may have bit-rotted for that build in the meantime, but it doesn't stop my from saying: ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Cole Robinson -
Eric Blake