[libvirt] libvirt-guests and ./configure --without-libvirtd
On mingw, libvirt is typically configured --without-libvirtd, because the mingw build is designed to target other hosts, but cannot natively run as a hypervisor. Additionally, mingw doesn't really have a notion of /etc/sysconf, so installing /etc/sysconfig/libvirt-guests doesn't work too well. Should tools/Makefile.am make the build and installation of libvirt-guests dependent on the already-existing WITH_LIBVIRTD Makefile conditional, or would it ever make sense to build libvirt-guests but not libvirtd? I guess the answer to that boils down to whether it ever makes sense to use libvirt-guests on a system that is not running libvirtd, in which case it would only be able to control remote URIs. But the whole point of the script is to cleanly save state for local VMs, so I don't see using libvirt-guests as a management tool for remote URIs. Unless anyone speaks up with another opinion, I'll prepare a patch that makes libvirt-guests depend on WITH_LIBVIRTD. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Unless anyone speaks up with another opinion, I'll prepare a patch that makes libvirt-guests depend on WITH_LIBVIRTD.
The init script is part of libvirt-client package because it doesn't require libvirtd. On hosts with VirtualBox hypervisor, libvirtd is not needed and libvirt-guests script can still handle guests on host shutdown/startup. The installation of the init script and corresponding sysconfig file depends on LIBVIRT_INIT_SCRIPT_RED_HAT, which feels like it doesn't make sense to enable it on mingw. Isn't it sufficient? Jirka
On 09/03/2010 12:34 PM, Jiri Denemark wrote:
Unless anyone speaks up with another opinion, I'll prepare a patch that makes libvirt-guests depend on WITH_LIBVIRTD.
The init script is part of libvirt-client package because it doesn't require libvirtd. On hosts with VirtualBox hypervisor, libvirtd is not needed and libvirt-guests script can still handle guests on host shutdown/startup.
The installation of the init script and corresponding sysconfig file depends on LIBVIRT_INIT_SCRIPT_RED_HAT, which feels like it doesn't make sense to enable it on mingw. Isn't it sufficient?
So the real bug, then, is that when cross-compiling from fedora->mingw, that LIBVIRT_INIT_SCRIPT_RED_HAT is being defined even though it shouldn't be. Thanks; I think I can figure out something to fix that, then. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Jiri Denemark