[libvirt] [PATCH] util: Remove ATTRIBUTE_NONNULL from virClassNew()
When compiling with Coverity, the STATIC_ANALYSIS was set to true which triggered the ATTRIBUTE_NONNULL check from src/internal.h. Since virClassNew now expects to be called with NULL under a special condition, this check is no longer valid. --- src/util/virobject.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virobject.h b/src/util/virobject.h index bb72a25..f58a950 100644 --- a/src/util/virobject.h +++ b/src/util/virobject.h @@ -54,8 +54,7 @@ virClassPtr virClassForObjectLockable(void); virClassPtr virClassNew(virClassPtr parent, const char *name, size_t objectSize, - virObjectDisposeCallback dispose) - ATTRIBUTE_NONNULL(1); + virObjectDisposeCallback dispose); const char *virClassName(virClassPtr klass) ATTRIBUTE_NONNULL(1); -- 1.7.11.7
On 01/22/2013 07:16 AM, John Ferlan wrote:
When compiling with Coverity, the STATIC_ANALYSIS was set to true which triggered the ATTRIBUTE_NONNULL check from src/internal.h. Since virClassNew now expects to be called with NULL under a special condition, this check is no longer valid.
I posted an alternative version, that only conditionally removes the attribute: https://www.redhat.com/archives/libvir-list/2013-January/msg01589.html
virClassPtr virClassNew(virClassPtr parent, const char *name, size_t objectSize, - virObjectDisposeCallback dispose) - ATTRIBUTE_NONNULL(1); + virObjectDisposeCallback dispose);
const char *virClassName(virClassPtr klass) ATTRIBUTE_NONNULL(1);
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
John Ferlan