[libvirt] [PATCH] openvzDomainCreateWithFlags: set domain id to the correct value
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
I'm not sure if it's ok or not to modify dom->id as I did here.
Regards,
Jean-Baptiste
Attachments:
- 0001-openvzDomainCreateWithFlags-set-domain-id-to-the-cor.patch (text/x-patch — 966 bytes)
2010/7/30 Jean-Baptiste Rouault <jean-baptiste.rouault(a)diateam.net>:
I'm not sure if it's ok or not to modify dom->id as I did
here.
Regards,
Jean-Baptiste
I think this is a bug that needs to be fixed and the patch is correct.
After starting a domain it has to have a valid ID >= 0.
I'm currently checking the other drivers, and the ESX and XenAPI
drivers are affected too.
The QEMU driver is also affected, but because it's always tunneled
through the remote driver and the remote driver isn't affected, this
problem doesn't surface for the QEMU driver. The same is true for the
LXC, UML and ONE drivers.
Matthias
2010/7/30 Matthias Bolte <matthias.bolte(a)googlemail.com>:
2010/7/30 Jean-Baptiste Rouault
<jean-baptiste.rouault(a)diateam.net>:
> I'm not sure if it's ok or not to modify dom->id as I did here.
>
> Regards,
> Jean-Baptiste
>
I think this is a bug that needs to be fixed and the patch is correct.
After starting a domain it has to have a valid ID >= 0.
I'm currently checking the other drivers, and the ESX and XenAPI
drivers are affected too.
The QEMU driver is also affected, but because it's always tunneled
through the remote driver and the remote driver isn't affected, this
problem doesn't surface for the QEMU driver. The same is true for the
LXC, UML and ONE drivers.
Matthias
ACK to your patch, I applied and pushed it.
This ID update problem exists in several other drivers too and I
posted patches to fix them.
Thanks for reporting and fixing this one, with the side effect of
revealing this as a general problem.
Matthias
5229
days inactive
5229
days old
2 comments
2 participants
tags (0)
participants (2)
-
Jean-Baptiste Rouault -
Matthias Bolte