[libvirt] [PATCH] spec: Enable ESX driver on RHEL
--- libvirt.spec.in | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5ea3422..fd99a54 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -87,7 +87,7 @@ %define with_numactl 0 %endif -# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, ESX, +# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, # VMWare, or libxenserver (xenapi) %if 0%{?rhel} %define with_openvz 0 @@ -95,7 +95,6 @@ %define with_uml 0 %define with_one 0 %define with_phyp 0 -%define with_esx 0 %define with_vmware 0 %define with_xenapi 0 %endif -- 1.7.3.4
On 12/23/2010 04:52 AM, Jiri Denemark wrote:
--- libvirt.spec.in | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 5ea3422..fd99a54 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -87,7 +87,7 @@ %define with_numactl 0 %endif
-# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, ESX, +# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, # VMWare, or libxenserver (xenapi) %if 0%{?rhel}
Actually, I'm thinking it's better to do: %if 0%{%rhel} #disable all but esx %endif # Additionally, RHEL 5 lacks ESX. %if 0%{?rhel} < 6 %define with_esx 0 %endif So that we can share a single spec file among both RHEL versions. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
-# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, ESX, +# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, # VMWare, or libxenserver (xenapi) %if 0%{?rhel}
Actually, I'm thinking it's better to do:
%if 0%{%rhel} #disable all but esx %endif
# Additionally, RHEL 5 lacks ESX. %if 0%{?rhel} < 6 %define with_esx 0 %endif
So that we can share a single spec file among both RHEL versions.
We do enable esx driver even on RHEL 5 so we don't need to deal with it separately to share the spec file. Jirka
On 12/23/2010 10:04 AM, Jiri Denemark wrote:
-# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, ESX, +# RHEL doesn't ship OpenVZ, VBox, UML, OpenNebula, PowerHypervisor, # VMWare, or libxenserver (xenapi) %if 0%{?rhel}
Actually, I'm thinking it's better to do:
%if 0%{%rhel} #disable all but esx %endif
# Additionally, RHEL 5 lacks ESX. %if 0%{?rhel} < 6 %define with_esx 0 %endif
So that we can share a single spec file among both RHEL versions.
We do enable esx driver even on RHEL 5 so we don't need to deal with it separately to share the spec file.
Good to hear. ACK as-is, then. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Jiri Denemark