3:03 p.m.
With VBox 5.1.x release new SDK header needs to be added to libvirt
sources. Sending as attachments due to the size of the first patch
being a large header file taken from VBOX SDK.
Dawid Zamirski (2):
vbox: add vbox 5.1 C API header file.
vbox: hookup the 5.1 C API to the unified driver.
src/Makefile.am | 1 +
src/vbox/vbox_CAPI_v5_1.h | 26117 ++++++++++++++++++++++++++++++++++++++++
src/vbox/vbox_V5_1.c | 13 +
src/vbox/vbox_common.h | 2 +
src/vbox/vbox_storage.c | 2 +
src/vbox/vbox_tmpl.c | 2 +
src/vbox/vbox_uniformed_api.h | 1 +
7 files changed, 26138 insertions(+)
create mode 100644 src/vbox/vbox_CAPI_v5_1.h
create mode 100644 src/vbox/vbox_V5_1.c
--
2.9.3
3:03 p.m.
New subject: [libvirt] [PATCH 2/2] vbox: hookup the 5.1 C API to the unified driver.
simply follow the same pattern as other versions did.
---
src/Makefile.am | 1 +
src/vbox/vbox_V5_1.c | 13 +++++++++++++
src/vbox/vbox_common.h | 2 ++
src/vbox/vbox_storage.c | 2 ++
src/vbox/vbox_tmpl.c | 2 ++
src/vbox/vbox_uniformed_api.h | 1 +
6 files changed, 21 insertions(+)
create mode 100644 src/vbox/vbox_V5_1.c
3:54 a.m.
New subject: [libvirt] [PATCH 2/2] vbox: hookup the 5.1 C API to the unified driver.
On Mon, Nov 07, 2016 at 04:03:43PM -0500, Dawid Zamirski wrote:
simply follow the same pattern as other versions did.
---
src/Makefile.am | 1 +
src/vbox/vbox_V5_1.c | 13 +++++++++++++
src/vbox/vbox_common.h | 2 ++
src/vbox/vbox_storage.c | 2 ++
src/vbox/vbox_tmpl.c | 2 ++
src/vbox/vbox_uniformed_api.h | 1 +
6 files changed, 21 insertions(+)
create mode 100644 src/vbox/vbox_V5_1.c
ACK, I'll push both patches.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
3:18 p.m.
New subject: [libvirt] [PATCH 1/2] vbox: add vbox 5.1 header file
extracted from vbox SDK and reindented with cppi
9:47 a.m.
On Mon, 2016-11-07 at 16:03 -0500, Dawid Zamirski wrote:
With VBox 5.1.x release new SDK header needs to be added to libvirt
sources. Sending as attachments due to the size of the first patch
being a large header file taken from VBOX SDK.
Dawid Zamirski (2):
vbox: add vbox 5.1 C API header file.
vbox: hookup the 5.1 C API to the unified driver.
Would you mind drafting one or two short sentences to describe
the impact of these changes for users? If everything goes
according to plans[1], they will be added to the NEWS file.
Thanks!
[1] Which it often doesn't :)
--
Andrea Bolognani / Red Hat / Virtualization
10:16 a.m.
On Fri, 2016-11-18 at 16:47 +0100, Andrea Bolognani wrote:
Would you mind drafting one or two short sentences to describe
the impact of these changes for users? If everything goes
according to plans[1], they will be added to the NEWS file.
Thanks!
[1] Which it often doesn't :)
--
Andrea Bolognani / Red Hat / Virtualization
Hi Andrea,
Sure, in this case those patches simply enable support of VirtualBox
5.1.x series in libvirt (prior to that libvirt supported vbox 2.x.x to
5.0.x)- and as such it does not affect any previous version that
libvirt supported. When upstream VirtualBox releases new version
bumping major/minor version tag it is usually coupled with new COM IID
strings that are bundled in the SDK which essentially bumps the VBOX
API version as well. Adding those SDK headers to livirt, enables it to
communicate with the updated VBOX COM interface and avoids "unsupported
API version" error message when one does virsh -c vbox:///session with
VirtualBox 5.1.x installed on the machine.
Regards,
Dawid
11:57 a.m.
On Fri, 2016-11-18 at 11:16 -0500, Dawid Zamirski wrote:
Hi Andrea,
Sure, in this case those patches simply enable support of VirtualBox
5.1.x series in libvirt (prior to that libvirt supported vbox 2.x.x
to
5.0.x)- and as such it does not affect any previous version that
libvirt supported. When upstream VirtualBox releases new version
bumping major/minor version tag it is usually coupled with new COM
IID
strings that are bundled in the SDK which essentially bumps the VBOX
API version as well. Adding those SDK headers to livirt, enables it
to
communicate with the updated VBOX COM interface and avoids
"unsupported
API version" error message when one does virsh -c vbox:///session
with
VirtualBox 5.1.x installed on the machine.
Regards,
Dawid
Another try after realizing it's for official NEWS entry :-)
"Added support for API compatibility with VitualBox 5.1.x"
7:52 a.m.
On Fri, 2016-11-18 at 12:57 -0500, Dawid Zamirski wrote:
On Fri, 2016-11-18 at 11:16 -0500, Dawid Zamirski wrote:
>
> Hi Andrea,
>
> Sure, in this case those patches simply enable support of VirtualBox
> 5.1.x series in libvirt (prior to that libvirt supported vbox 2.x.x
> to
> 5.0.x)- and as such it does not affect any previous version that
> libvirt supported. When upstream VirtualBox releases new version
> bumping major/minor version tag it is usually coupled with new COM
> IID
> strings that are bundled in the SDK which essentially bumps the VBOX
> API version as well. Adding those SDK headers to livirt, enables it
> to
> communicate with the updated VBOX COM interface and avoids
> "unsupported
> API version" error message when one does virsh -c vbox:///session
> with
> VirtualBox 5.1.x installed on the machine.
Another try after realizing it's for official NEWS entry :-)
"Added support for API compatibility with VitualBox 5.1.x"
Thanks, I've reworked it a bit and pushed it :)
--
Andrea Bolognani / Red Hat / Virtualization
2922
days inactive
2937
days old
7 comments
3 participants
participants (3)
-
Andrea Bolognani -
Daniel P. Berrange -
Dawid Zamirski