[PATCH] tests: Don't leak cpu defs

There are cpu definitions that are allocated in qemuTestDriverInit() but are missing corresponding virCPUDefFree() call in qemuTestDriverFree(). It's safe to call the free function because the definitions contain a refcounter and thus even if they were still in use the refcounter would be just decreased. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/testutilsqemu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index fab676c070..9a0666724a 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -332,6 +332,11 @@ void qemuTestDriverFree(virQEMUDriver *driver) virObjectUnref(driver->caps); virObjectUnref(driver->config); virObjectUnref(driver->securityManager); + + virCPUDefFree(cpuDefault); + virCPUDefFree(cpuHaswell); + virCPUDefFree(cpuPower8); + virCPUDefFree(cpuPower9); } int qemuTestCapsCacheInsert(virFileCache *cache, -- 2.31.1

On a %A in %Y, Michal Privoznik wrote:
There are cpu definitions that are allocated in qemuTestDriverInit() but are missing corresponding virCPUDefFree() call in qemuTestDriverFree(). It's safe to call the free function because the definitions contain a refcounter and thus even if they were still in use the refcounter would be just decreased.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tests/testutilsqemu.c | 5 +++++ 1 file changed, 5 insertions(+)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
participants (2)
-
Jano Tomko
-
Michal Privoznik