3:35 a.m.
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
---
docs/aclpolkit.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in
index 91b5296..e5a9b16 100644
--- a/docs/aclpolkit.html.in
+++ b/docs/aclpolkit.html.in
@@ -121,7 +121,7 @@
<td>Name of the network interface, unique to the local host</td>
</tr>
<tr>
- <td>interface_mac</td>
+ <td>interface_macaddr</td>
<td>MAC address of the network interface, not unique</td>
</tr>
</tbody>
--
1.8.3.1
3:47 a.m.
On 11/07/2014 10:35 AM, Luyao Huang wrote:
>From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
---
docs/aclpolkit.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK. I modified the commit message to point to the BZ
(https://bugzilla.redhat.com/show_bug.cgi?id=1161358) and pushed.
diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in
index 91b5296..e5a9b16 100644
--- a/docs/aclpolkit.html.in
+++ b/docs/aclpolkit.html.in
@@ -121,7 +121,7 @@
<td>Name of the network interface, unique to the local host</td>
</tr>
<tr>
- <td>interface_mac</td>
+ <td>interface_macaddr</td>
<td>MAC address of the network interface, not unique</td>
</tr>
</tbody>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
3:53 a.m.
On 11/07/2014 10:47 AM, Eric Blake wrote:
On 11/07/2014 10:35 AM, Luyao Huang wrote:
> >From virAccessDriverPolkitCheckInterface function, we know this
> attribute should named: interface_macaddr
Eww. 'git am' strips an initial commit line beginning with ">From ",
if
it doesn't match an email address (this is because it special cases a
leading 'From: ...' or '>From: ...' line as overriding commit
authorship
instead of using the email's sender as the author). I didn't realize
that I lost a line of your commit message until after I had pushed my
modifications.
In the future, try to avoid using "From" as the first word of a commit
message. "Based on the" could serve as an appropriate substitute phrase
for this case.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4:02 a.m.
On 11/07/2014 05:53 PM, Eric Blake wrote:
On 11/07/2014 10:47 AM, Eric Blake wrote:
> On 11/07/2014 10:35 AM, Luyao Huang wrote:
>> >From virAccessDriverPolkitCheckInterface function, we know this
>> attribute should named: interface_macaddr
Eww. 'git am' strips an initial commit line beginning with ">From ",
if
it doesn't match an email address (this is because it special cases a
leading 'From: ...' or '>From: ...' line as overriding commit
authorship
instead of using the email's sender as the author). I didn't realize
that I lost a line of your commit message until after I had pushed my
modifications.
In the future, try to avoid using "From" as the first word of a commit
message. "Based on the" could serve as an appropriate substitute phrase
for this case.
So interesting :)
i didn't notice this before.I will change my word
next time, thanks your advice.
3704
days inactive
3704
days old
3 comments
3 participants
participants (3)
-
Eric Blake -
lhuang -
Luyao Huang