[Libvir] Ensure errors are reported against virConnect object
In xend_internal.c there are a large number of places where errors are being reported without supplying an associated virConnectPtr object. So for example when calling virDomainCreateLinux, some errors get associated with the connection object, while others get attached to the global error object. The attached patch fixes up all places in xend_internal.c which have an virConnectPtr object available to always pass this object into the the error reporting funcs. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Wed, Oct 25, 2006 at 07:20:30PM +0100, Daniel P. Berrange wrote:
In xend_internal.c there are a large number of places where errors are being reported without supplying an associated virConnectPtr object. So for example when calling virDomainCreateLinux, some errors get associated with the connection object, while others get attached to the global error object. The attached patch fixes up all places in xend_internal.c which have an virConnectPtr object available to always pass this object into the the error reporting funcs.
Yup makes perfect sense. A lot of this was the result of plugging existing code from Anthony, so the data was not passed down, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel P. Berrange -
Daniel Veillard