[libvirt] [PATCH] qemuagenttest.c: Missing documentation (Timeout)
From: Nehal J Wani <nehaljw.kkd1@gmail.com> In tests/qemuagenttest.c, the Timeout test should always be called last. Any additional tests should come before this. --- tests/qemuagenttest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index e338c98..cf32fc4 100644 --- a/tests/qemuagenttest.c +++ b/tests/qemuagenttest.c @@ -605,7 +605,8 @@ mymain(void) DO_TEST(Shutdown); DO_TEST(CPU); DO_TEST(ArbitraryCommand); - DO_TEST(Timeout); + + DO_TEST(Timeout); /*Timeout should always be called last*/ virObjectUnref(xmlopt); -- 1.7.11.7
On 08/22/2013 01:43 PM, nehaljwani wrote:
From: Nehal J Wani <nehaljw.kkd1@gmail.com>
In tests/qemuagenttest.c, the Timeout test should always be called last. Any additional tests should come before this.
Especially after IRC conversations today, where trying to add a test after this point led to some head-scratching while debugging.
--- tests/qemuagenttest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
ACK and pushed. Congrats on your first upstream libvirt patch.
diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index e338c98..cf32fc4 100644 --- a/tests/qemuagenttest.c +++ b/tests/qemuagenttest.c @@ -605,7 +605,8 @@ mymain(void) DO_TEST(Shutdown); DO_TEST(CPU); DO_TEST(ArbitraryCommand); - DO_TEST(Timeout); + + DO_TEST(Timeout); /*Timeout should always be called last*/
Style nit - we prefer spaces between /* content */ -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
nehaljwani