[libvirt] [PATCH] virt-host-validate: require fuse for LXC if compiled in
Domains fail to start without fuse like error: internal error: guest failed to start: fuse: device not found, try 'modprobe fuse' first Failure in libvirt_lxc startup: no error so check for it too. References: https://ci.debian.net/data/autopkgtest/unstable/amd64/libv/libvirt/20171012_... --- tools/virt-host-validate-lxc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 2b906cc88a..64d9279c30 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -93,5 +93,12 @@ int virHostValidateLXC(void) "BLK_CGROUP") < 0) ret = -1; +#if WITH_FUSE + if (virHostValidateDeviceExists("LXC", "/sys/fs/fuse/connections", + VIR_HOST_VALIDATE_FAIL, + _("Load the 'fuse' module to enable /proc/ overrides")) < 0) + ret = -1; +#endif + return ret; } -- 2.14.2
On Thu, Oct 12, 2017 at 05:53:21PM +0200, Guido Günther wrote:
Domains fail to start without fuse like
error: internal error: guest failed to start: fuse: device not found, try 'modprobe fuse' first Failure in libvirt_lxc startup: no error
so check for it too.
References: https://ci.debian.net/data/autopkgtest/unstable/amd64/libv/libvirt/20171012_... --- tools/virt-host-validate-lxc.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 2b906cc88a..64d9279c30 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -93,5 +93,12 @@ int virHostValidateLXC(void) "BLK_CGROUP") < 0) ret = -1;
+#if WITH_FUSE + if (virHostValidateDeviceExists("LXC", "/sys/fs/fuse/connections", + VIR_HOST_VALIDATE_FAIL, + _("Load the 'fuse' module to enable /proc/ overrides")) < 0) + ret = -1; +#endif + return ret; }
Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Hi, On Thu, Oct 12, 2017 at 05:25:34PM +0100, Daniel P. Berrange wrote:
On Thu, Oct 12, 2017 at 05:53:21PM +0200, Guido Günther wrote:
Domains fail to start without fuse like
error: internal error: guest failed to start: fuse: device not found, try 'modprobe fuse' first Failure in libvirt_lxc startup: no error
so check for it too.
References: https://ci.debian.net/data/autopkgtest/unstable/amd64/libv/libvirt/20171012_... --- tools/virt-host-validate-lxc.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 2b906cc88a..64d9279c30 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -93,5 +93,12 @@ int virHostValidateLXC(void) "BLK_CGROUP") < 0) ret = -1;
+#if WITH_FUSE + if (virHostValidateDeviceExists("LXC", "/sys/fs/fuse/connections", + VIR_HOST_VALIDATE_FAIL, + _("Load the 'fuse' module to enable /proc/ overrides")) < 0) + ret = -1; +#endif + return ret; }
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Pushed. thanks! -- Guido
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Guido Günther <agx@sigxcpu.org> 10/12/17 6:12 PM >>> Domains fail to start without fuse like
error: internal error: guest failed to start: fuse: device not found, try 'modprobe fuse' first Failure in libvirt_lxc startup: no error so check for it too. References: https://ci.debian.net/data/autopkgtest/unstable/amd64/libv/libvirt/20171012_... --- tools/virt-host-validate-lxc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 2b906cc88a..64d9279c30 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -93,5 +93,12 @@ int virHostValidateLXC(void) "BLK_CGROUP") < 0) ret = -1; +#if WITH_FUSE + if (virHostValidateDeviceExists("LXC", "/sys/fs/fuse/connections", + VIR_HOST_VALIDATE_FAIL, + _("Load the 'fuse' module to enable /proc/ overrides")) < 0) + ret = -1; +#endif + return ret; } ACK -- Cedric
participants (3)
-
Cedric Bosdonnat -
Daniel P. Berrange -
Guido Günther