[libvirt] [PATCH] Fix minor virsh man page typos and formatting problems.
--- tools/virsh.pod | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 422ae7f..79900e5 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -89,7 +89,7 @@ Running hypervisor: Xen 3.0.0 =back -=item B<cd> I<directory> optional +=item B<cd> optional I<directory> Will change current directory to I<directory>. The default directory for the B<cd> command is the home directory or, if there is no I<HOME> @@ -273,13 +273,13 @@ pre-existing guest. B<Example> -virsh dumpxml <domain-id> > domain.xml -edit domain.xml -virsh create < domain.xml + virsh dumpxml <domain-id> > domain.xml + edit domain.xml + virsh create domain.xml =item B<define> I<FILE> -Define a domain from an XML <file>. The domain definitions is registered +Define a domain from an XML <file>. The domain definition is registered but not started. =item B<destroy> I<domain-id> @@ -490,7 +490,7 @@ is not available the processes will provide an exit code of 1. =item B<undefine> I<domain-id> Undefine the configuration for an inactive domain. Since it's not running -the domain name or UUId must be used as the I<domain-id>. +the domain name or UUID must be used as the I<domain-id>. =item B<vcpuinfo> I<domain-id> -- 1.7.0.1
On 06/05/2010 04:39 AM, Justin Clift wrote:
--- tools/virsh.pod | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index 422ae7f..79900e5 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -89,7 +89,7 @@ Running hypervisor: Xen 3.0.0 =back -=item B<cd> I<directory> optional +=item B<cd> optional I<directory>
Thanks for catching these! This patch came across as corrupted for me; notice the space inserted before the leading -, and the missing blank lines. Possibly due to a botched mime type from your mailer? I went ahead and manually applied the intended changes, but don't want to make a habit of spending that much time on broken patches. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 06/08/2010 10:23 AM, Eric Blake wrote:
On 06/05/2010 04:39 AM, Justin Clift wrote:
--- tools/virsh.pod | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index 422ae7f..79900e5 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -89,7 +89,7 @@ Running hypervisor: Xen 3.0.0 =back -=item B<cd> I<directory> optional +=item B<cd> optional I<directory>
Thanks for catching these!
This patch came across as corrupted for me; notice the space inserted before the leading -, and the missing blank lines. Possibly due to a botched mime type from your mailer?
Ouch, no worries. Looks like either my process is bad, or Thunderbird isn't handing things so well. :(
I went ahead and manually applied the intended changes, but don't want to make a habit of spending that much time on broken patches.
Understood. I'll look into other mailers. Sorry for the hassle. Regards and best wishes, Justin Clift -- Salasaga - Open Source eLearning IDE http://www.salasaga.org
On Tue, Jun 08, 2010 at 04:36:05PM +1000, Justin Clift wrote:
On 06/08/2010 10:23 AM, Eric Blake wrote:
On 06/05/2010 04:39 AM, Justin Clift wrote:
--- tools/virsh.pod | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index 422ae7f..79900e5 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -89,7 +89,7 @@ Running hypervisor: Xen 3.0.0 =back -=item B<cd> I<directory> optional +=item B<cd> optional I<directory>
Thanks for catching these!
This patch came across as corrupted for me; notice the space inserted before the leading -, and the missing blank lines. Possibly due to a botched mime type from your mailer?
Ouch, no worries. Looks like either my process is bad, or Thunderbird isn't handing things so well. :(
I went ahead and manually applied the intended changes, but don't want to make a habit of spending that much time on broken patches.
Understood. I'll look into other mailers.
For just sending patches to the list, the simplest way is to just use GIT itself. eg, my workflow is to create a branch for all my changes, and then periodically spam the list with the changes on the branch git checkout -b mywork ...make some commits on 'mywork' branch git send-email \ --compose \ --no-chain-reply-to \ --to libvir-list@redhat.com master.. Since we're on 'mybranch', the tag 'master..' means send all the commits made on the branch that aren't in master. The '--compose' is good if you're sending a series of patches, making it display an editor for writing the covering letter. The commit messages form the body of each mail. Tip when learning to use git send-email is to send the email to yourself instead of the mailing list first :-) Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On 06/08/2010 06:32 PM, Daniel P. Berrange wrote: <snip>
Tip when learning to use git send-email is to send the email to yourself instead of the mailing list first :-)
Thanks Daniel. After much gnashing of teeth and getting the hang of things, this looks to be working now when sending to myself. Just sent through the vol-pool patch again, this time using git send-email. If that come through ok, I'll resubmit the rest in a bit. Regards and best wishes, Justin Clift
Regards, Daniel
-- Salasaga - Open Source eLearning IDE http://www.salasaga.org
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Justin Clift