[libvirt] [PATCH] Resolve COPY_PASTE error found by Coverity
Fix copy-paste error doing handshake. The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index a1e71dc..49462df 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -662,7 +662,7 @@ static int testTLSSessionInit(const void *opaque) if (rv < 0) goto cleanup; if (rv == VIR_NET_TLS_HANDSHAKE_COMPLETE) - serverShake = true; + clientShake = true; } } while (!clientShake && !serverShake); -- 1.7.11.7
On Tue, Jan 08, 2013 at 10:10:10AM -0500, John Ferlan wrote:
Fix copy-paste error doing handshake.
The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index a1e71dc..49462df 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -662,7 +662,7 @@ static int testTLSSessionInit(const void *opaque) if (rv < 0) goto cleanup; if (rv == VIR_NET_TLS_HANDSHAKE_COMPLETE) - serverShake = true; + clientShake = true; } } while (!clientShake && !serverShake);
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 08.01.2013 16:17, Daniel P. Berrange wrote:
On Tue, Jan 08, 2013 at 10:10:10AM -0500, John Ferlan wrote:
Fix copy-paste error doing handshake.
The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index a1e71dc..49462df 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -662,7 +662,7 @@ static int testTLSSessionInit(const void *opaque) if (rv < 0) goto cleanup; if (rv == VIR_NET_TLS_HANDSHAKE_COMPLETE) - serverShake = true; + clientShake = true; } } while (!clientShake && !serverShake);
ACK
Daniel
Pushed now. Michal
participants (3)
-
Daniel P. Berrange -
John Ferlan -
Michal Privoznik