[libvirt] [PATCH 0/2] news: Update for v3.3.0
The release notes have been almost completely neglected this cycle, so I've spent some time going through the git log and trying to include what to me looked like relevant changes. Summaries and descriptions are going to be worse that they would be if they were written by the people implementing the changes, but I reckon it's still better than nothing :) Reviews are much appreciated, but if I won't get any feedback I will push this anyway before release just so that v3.3.0 doesn't end up including such sorry excuse for release notes in the final tarball. Andrea Bolognani (2): news: Tweak existing v3.3.0 entries news: Add more v3.3.0 entries docs/news.xml | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 119 insertions(+), 4 deletions(-) -- 2.7.4
Some of the content was not following the (loosely established) style, and some of the XML was not aligned properly. --- docs/news.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 7dda8db..36d2ee3 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -39,25 +39,25 @@ <section title="Improvements"> <change> <summary> - The libvirt Hyper-V driver now supports Hyper-V 2012 and newer. + hyperv: Support Hyper-V 2012 and newer </summary> <description> Starting with Hyper-V 2012 the API has changed causing the existing driver to be unable to send and process requests properly. This has been resolved by adding abstractions to handle the differences and ease handling such breaks if they happen in the future. - </description> + </description> </change> <change> <summary> - Add support for nested HVM domains in the libxl driver + libxl: Add support for nested HVM domains </summary> <description> Xen has supported nested HVM domains since version 4.4. The libvirt libxl driver now supports nested HVM domains by specifying the host-passthrough CPU mode when defining a domain. - </description> + </description> </change> </section> <section title="Bug fixes"> -- 2.7.4
On Tue, May 02, 2017 at 18:22:44 +0200, Andrea Bolognani wrote:
Some of the content was not following the (loosely established) style, and some of the XML was not aligned properly. --- docs/news.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
ACK
These entries cover a number of features, improvements and bug fixes that had not been documented during the development cycle. --- docs/news.xml | 115 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 36d2ee3..38dc17f 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,29 @@ <libvirt> <release version="v3.3.0" date="unreleased"> <section title="New features"> + <change> + <summary> + net: Add support for coalesce settings + </summary> + <description> + Enabling data batching through these settings can improve network + performance for guests. + </description> + </change> + <change> + <summary> + qemu: Add support for guest CPU cache specification + </summary> + <description> + This features allows fine-grained control of the cache behavior + of the guest CPU. + </description> + </change> + <change> + <summary> + qemu: Add support for the qemu-xhci USB controller + </summary> + </change> </section> <section title="Improvements"> <change> @@ -59,8 +82,100 @@ domain. </description> </change> + <change> + <summary> + qemu: Implement ACPI support for aarch64 guests + </summary> + <description> + Up until this point, ACPI support was only advertised for x86_64 + guests and disabling it for aarch64 guests was not possible at all. + </description> + </change> + <change> + <summary> + vz: Add support for changing the number of vCPUs + </summary> + </change> + <change> + <summary> + qemu: Automatically choose the best USB controller for guests + </summary> + <description> + The recently introduced qemu-xhci USB controller is the best choice + for both ppc64 and aarch64 guests, so use it by default on those + architectures if available. + </description> + </change> + <change> + <summary> + daemon: Increase default task limit for libvirtd + </summary> + <description> + The default number of tasks for the pids cgroup controller is 512, + which libvirtd can quickly bump into when starting lots of guests. + Raise the limit to a more reasonable 32768. + </description> + </change> + <change> + <summary> + docs: Include man pages describing key code names and values + </summary> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + nss: Don't require a network restart for libvirt_guest + </summary> + <description> + Previously, the libvirt_guest NSS module would only work properly + after the corresponding network had been restarted; now newly + started guests will be reported correctly right away. + </description> + </change> + <change> + <summary> + storage: Remove unavailable transient pools after restart + </summary> + <description> + Solve an issue where transient storage pools would be stuck in an + unmanageable state if the source disappeared and libvirtd was + subsequently restarted. + </description> + </change> + <change> + <summary> + storage: Fix capacity value for LUKS encrypted volumes + </summary> + <description> + The 'capacity' value (e.g. guest logical size) for a LUKS volume is + smaller than the 'physical' value of the file in the file system, so + we need to account for that. + </description> + </change> + <change> + <summary> + qemu: Fix regression when hyperv/vendor_id feature is used + </summary> + <description> + Guests using the feature would not be started at all; it is now + possible to start them as expected. + </description> + </change> + <change> + <summary> + qemu: Do not crash on USB address with no port and invalid bus + </summary> + </change> + <change> + <summary> + virsh: Report initialization errors + </summary> + <description> + Sometimes virsh might be unable to start: when that happens, report + useful diagnostics instead of failing silently. + </description> + </change> </section> </release> <release version="v3.2.0" date="2017-04-02"> -- 2.7.4
On Tue, May 02, 2017 at 18:23:08 +0200, Andrea Bolognani wrote:
These entries cover a number of features, improvements and bug fixes that had not been documented during the development cycle. --- docs/news.xml | 115 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml index 36d2ee3..38dc17f 100644 --- a/docs/news.xml +++ b/docs/news.xml
<section title="Bug fixes"> + <change> + <summary> + nss: Don't require a network restart for libvirt_guest + </summary> + <description> + Previously, the libvirt_guest NSS module would only work properly + after the corresponding network had been restarted; now newly + started guests will be reported correctly right away. + </description> + </change> + <change> + <summary> + storage: Remove unavailable transient pools after restart + </summary> + <description> + Solve an issue where transient storage pools would be stuck in an + unmanageable state if the source disappeared and libvirtd was + subsequently restarted. + </description> + </change> + <change> + <summary> + storage: Fix capacity value for LUKS encrypted volumes + </summary> + <description> + The 'capacity' value (e.g. guest logical size) for a LUKS volume is + smaller than the 'physical' value of the file in the file system, so + we need to account for that. + </description>
Rather than this I'd mention the bug in the padding of data passed to qemu: 71890992daf37ec78b00b4ce873369421dc99731
+ </change> + <change> + <summary> + qemu: Fix regression when hyperv/vendor_id feature is used + </summary> + <description> + Guests using the feature would not be started at all; it is now + possible to start them as expected. + </description> + </change> + <change> + <summary> + qemu: Do not crash on USB address with no port and invalid bus + </summary> + </change> + <change> + <summary> + virsh: Report initialization errors + </summary> + <description> + Sometimes virsh might be unable to start: when that happens, report + useful diagnostics instead of failing silently.
This does not seem to be a bugfix, but rather an improvement.
+ </description> + </change> </section> </release> <release version="v3.2.0" date="2017-04-02">
ACK
On Wed, 2017-05-03 at 09:19 +0200, Peter Krempa wrote:
+ <summary> + storage: Fix capacity value for LUKS encrypted volumes + </summary> + <description> + The 'capacity' value (e.g. guest logical size) for a LUKS volume is + smaller than the 'physical' value of the file in the file system, so + we need to account for that. + </description> Rather than this I'd mention the bug in the padding of data passed to qemu: 71890992daf37ec78b00b4ce873369421dc99731
Why not both? :) However, I'm unable to find that commit in either libvirt's or QEMU's git repositories, are you sure it's correct? If you can point me to it I can definitely add an entry for it.
+ <summary> + virsh: Report initialization errors + </summary> + <description> + Sometimes virsh might be unable to start: when that happens, report + useful diagnostics instead of failing silently. This does not seem to be a bugfix, but rather an improvement.
I've moved it and pushed the series. -- Andrea Bolognani / Red Hat / Virtualization
On Wed, May 03, 2017 at 05:11:29PM +0200, Andrea Bolognani wrote:
On Wed, 2017-05-03 at 09:19 +0200, Peter Krempa wrote:
+ <summary> + storage: Fix capacity value for LUKS encrypted volumes + </summary> + <description> + The 'capacity' value (e.g. guest logical size) for a LUKS volume is + smaller than the 'physical' value of the file in the file system, so + we need to account for that. + </description> Rather than this I'd mention the bug in the padding of data passed to qemu: 71890992daf37ec78b00b4ce873369421dc99731
Why not both? :)
However, I'm unable to find that commit in either libvirt's or QEMU's git repositories, are you sure it's correct? If you can point me to it I can definitely add an entry for it.
commit 71890992daf37ec78b00b4ce873369421dc99731 Author: Daniel P. Berrange <berrange@redhat.com> AuthorDate: 2017-05-02 11:32:43 +0100 Commit: Daniel P. Berrange <berrange@redhat.com> CommitDate: 2017-05-02 17:27:13 +0100 Fix padding of encrypted data git describe: v3.3.0-rc1-3-g7189099 contains: v3.3.0-rc2~2 http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=71890992daf37ec78b00b4c... Jan
On Wed, 2017-05-03 at 17:25 +0200, Ján Tomko wrote:
Rather than this I'd mention the bug in the padding of data passed to qemu: 71890992daf37ec78b00b4ce873369421dc99731 Why not both? :) However, I'm unable to find that commit in either libvirt's or QEMU's git repositories, are you sure it's correct? If you can point me to it I can definitely add an entry for it. commit 71890992daf37ec78b00b4ce873369421dc99731 Author: Daniel P. Berrange <berrange@redhat.com> AuthorDate: 2017-05-02 11:32:43 +0100 Commit: Daniel P. Berrange <berrange@redhat.com> CommitDate: 2017-05-02 17:27:13 +0100 Fix padding of encrypted data git describe: v3.3.0-rc1-3-g7189099 contains: v3.3.0-rc2~2 http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=71890992daf37ec78b00b4c...
Yeah, apparently I had merely failed to fetch :/ I've posted patch 3/2, which adds an entry for that change. -- Andrea Bolognani / Red Hat / Virtualization
On 05/02/2017 10:22 AM, Andrea Bolognani wrote:
The release notes have been almost completely neglected this cycle, so I've spent some time going through the git log and trying to include what to me looked like relevant changes.
Yes, I noticed the neglected state when adding an entry for libxl nested HVM support.
Summaries and descriptions are going to be worse that they would be if they were written by the people implementing the changes, but I reckon it's still better than nothing :)
Reviews are much appreciated, but if I won't get any feedback I will push this anyway before release just so that v3.3.0 doesn't end up including such sorry excuse for release notes in the final tarball.
Andrea Bolognani (2): news: Tweak existing v3.3.0 entries news: Add more v3.3.0 entries
docs/news.xml | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 119 insertions(+), 4 deletions(-)
Reviewed-by: Jim Fehlig <jfehlig@suse.com> Regards, Jim
--- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8f6b768..593cc52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -176,6 +176,16 @@ qemu: Do not crash on USB address with no port and invalid bus </summary> </change> + <change> + <summary> + crypto: Always pad data before encrypting it + </summary> + <description> + If this step is not performed, when the data length matches the + chunk size the decryption routines will misinterpret the last byte + of data as the padding lenght and fail to decode it correctly. + </description> + </change> </section> </release> <release version="v3.2.0" date="2017-04-02"> -- 2.7.4
On Wed, May 03, 2017 at 06:03:23PM +0200, Andrea Bolognani wrote:
--- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml index 8f6b768..593cc52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -176,6 +176,16 @@ qemu: Do not crash on USB address with no port and invalid bus </summary> </change> + <change> + <summary> + crypto: Always pad data before encrypting it + </summary> + <description> + If this step is not performed, when the data length matches the + chunk size the decryption routines will misinterpret the last byte + of data as the padding lenght and fail to decode it correctly.
s/lenght/length/ ACK with that fixed I make no statement regarding its eligibility for the freeze (except this one). Jan
On Wed, 2017-05-03 at 18:16 +0200, Ján Tomko wrote: [...]
+ <description> + If this step is not performed, when the data length matches the + chunk size the decryption routines will misinterpret the last byte + of data as the padding lenght and fail to decode it correctly. s/lenght/length/ ACK with that fixed
Good catch. And of course I had to make a fool of myself by forgetting to fix it before pushing :/ -- Andrea Bolognani / Red Hat / Virtualization
participants (4)
-
Andrea Bolognani -
Jim Fehlig -
Ján Tomko -
Peter Krempa