[libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update
Restarting an active libvirt-guests.service is the equivalent of doing: /usr/libexec/libvirt-guests.sh stop /usr/libexec/libvirt-guests.sh start Which in a default configuration will managedsave every running VM, and then restore them. Certainly not something we should do every time the libvirt-client RPM is updated. Just drop the try-restart attempt, I don't know what purpose it serves anyways. https://bugzilla.redhat.com/show_bug.cgi?id=962225 --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a5b01df..0d50ccd 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1714,9 +1714,8 @@ fi # If the package is allowed to autostart: /bin/systemctl --no-reload enable libvirt-guests.service >/dev/null 2>&1 ||: -# Run these because the SysV package being removed won't do them +# Run this because the SysV package being removed won't do them /sbin/chkconfig --del libvirt-guests >/dev/null 2>&1 || : -/bin/systemctl try-restart libvirt-guests.service >/dev/null 2>&1 || : %endif %if %{with_sanlock} -- 1.8.4.2
On 11/21/2013 01:15 PM, Cole Robinson wrote:
Restarting an active libvirt-guests.service is the equivalent of doing:
/usr/libexec/libvirt-guests.sh stop /usr/libexec/libvirt-guests.sh start
Which in a default configuration will managedsave every running VM, and then restore them. Certainly not something we should do every time the libvirt-client RPM is updated.
Just drop the try-restart attempt, I don't know what purpose it serves anyways.
Probably put in as copy-and-paste from libvirtd by someone who didn't understand services very well at the time the script was created. For libvirtd, it DOES make sense to restart (you want to be running the latest bits for bug fixes, and restarting libvirtd has no impact to running guests).
https://bugzilla.redhat.com/show_bug.cgi?id=962225 --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
ACK. (and goes to crawl in a hole for not investigating this further back in May when I claimed it as a regression in behavior) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 11/21/2013 04:54 PM, Eric Blake wrote:
On 11/21/2013 01:15 PM, Cole Robinson wrote:
Restarting an active libvirt-guests.service is the equivalent of doing:
/usr/libexec/libvirt-guests.sh stop /usr/libexec/libvirt-guests.sh start
Which in a default configuration will managedsave every running VM, and then restore them. Certainly not something we should do every time the libvirt-client RPM is updated.
Just drop the try-restart attempt, I don't know what purpose it serves anyways.
Probably put in as copy-and-paste from libvirtd by someone who didn't understand services very well at the time the script was created. For libvirtd, it DOES make sense to restart (you want to be running the latest bits for bug fixes, and restarting libvirtd has no impact to running guests).
https://bugzilla.redhat.com/show_bug.cgi?id=962225 --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
ACK. (and goes to crawl in a hole for not investigating this further back in May when I claimed it as a regression in behavior)
Thanks, Pushed now - Cole
participants (2)
-
Cole Robinson -
Eric Blake