Re: [libvirt] [PATCH 03/10] Add an internal <secret> XML handling API

Tuesday, 8 September 2009



----- "Daniel Veillard" <veillard(a)redhat.com&gt; wrote:
...
 > +    default:
 > +        VIR_ERROR(_("unexpected secret usage type %d"),
def->usage_type);
 > +        break;
 
   Hum, since the virSecretDefPtr is allocated by our own code, it's
   probably better to remove the default so that the compiler can tell us
   we missed one enum case if new ones gets added. 
...
 > +    type_str = virXPathString(conn,
"string(./usage/@type)", ctxt);
 > +    if (type_str == NULL) {
 > +        virSecretReportError(conn, VIR_ERR_XML_ERROR, "%s",
 > +                             _("unknown secret usage type"));
 
   _("missing secret usage type") would be more appropriate I guess 
...
 > +    case VIR_SECRET_USAGE_TYPE_VOLUME:
 > +        def->usage.volume = virXPathString(conn,
"string(./usage/volume)",
 > +                                           ctxt);
 > +        break;
 > +
 > +    default:
 
   Again default: here means a mismatch between
   virSecretUsageTypeTypeFromString and this function, best handled
 statically IMHO. 
Thanks for the review, attached is an updated patch.
    Mirek

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005