On Tue, Aug 16, 2016 at 10:11:18 +0200, Peter Krempa wrote:
Error message in qemuDomainSetVcpusFlags uses %d for the two
arguments
but both are unsigned. The resulting error message may be weird when
attempting to set a very large vcpu count.
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5a7733c..a0587e1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4826,7 +4826,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
if (!(flags & VIR_DOMAIN_VCPU_MAXIMUM) && nvcpus > maxvcpus) {
virReportError(VIR_ERR_INVALID_ARG,
_("requested vcpus is greater than max allowable"
- " vcpus for the domain: %d > %d"),
+ " vcpus for the domain: %u > %u"),
nvcpus, maxvcpus);
Self NACK, I'll move this adjustment to patch 15/27 of my vcpu hotplug
series since it's touching the same code. Since that one is ACKed I
classify this as trivial enough to add to that patch.
Peter