On Thu, Jul 04, 2019 at 11:04:15AM +0200, Lubomir Rintel wrote: Can you elaborate on this a bit as I'm not seeing a way for this to happen with the current code. - virInitctlSetRunLevel returns 0 if no init was found, 1 if it was successful, -1 on error - lxcDomainInitctlCallback checks whether init exists and is not the same as the host init a then calls virInitctlSetRunLevel. Due to the checks virInitctlSetRunLevel can only ever return 1 or -1 in this scenario. 0 will never happen - virLXCDomainSetRunlevel calls lxcDomainInitctlCallback via virProcessRunInMountNamespace and honours the return status. So virLXCDomainSetRunlevel shoudl return -1 on error, 1 on success - lxcDomainShutdownFlags calls virLXCDomainSetRunlevel and saves its return value to a variable 'rc' - If 'rc' is -1 then it sends SIGTERM, otherwise it just returns 0 indicating success So I'm not following how we can end up successing talking to init, and then also sending SIGTERM. In fact there is a different problem here I believe. We should be sending SIGTERM when 'rc' is 0 not -1, because rc==0 is what indicates no init was present. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|