[libvirt] [PATCH] tests: securityselinuxlabel: Add QEMU_CAPS_VNC to fake qemuCaps
In commit 45270337f057f26ce484f6e forgot to make sure that tests pass. Add the missing capability to fix the test. Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- Pushed. tests/securityselinuxlabeltest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c index 192f2dc84f..3040a36693 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -351,6 +351,7 @@ mymain(void) return EXIT_FAILURE; virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_CIRRUS_VGA); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC); if (qemuTestCapsCacheInsert(driver.qemuCapsCache, qemuCaps) < 0) return EXIT_FAILURE; -- 2.23.0
On 12/17/19 4:04 AM, Peter Krempa wrote:
In commit 45270337f057f26ce484f6e forgot to make sure that tests pass. Add the missing capability to fix the test.
Thanks for the fixing this. FWIW I tested every commit individually, multiple times over as I was poking at this series over a few days. At one point I was hitting securityselinuxlabeltest failures, but when I would run the test directly it succeeded. Then I rebased to master and the test failure went away and I couldn't reproduce. I pushed the series to another machine and tests passed there too. There must be something that makes the test flakey, or ordering dependent maybe? Daniel obviously was running at least some portion of the test suite, considering most patches in the series had to adjust the test suite to match. - Cole
participants (2)
-
Cole Robinson -
Peter Krempa