[Libvir] [PATCH] Allow maxnames to be 0 in List{, Defined}{Domains, Networks}

It seems a bit pathological to check if maxNames <= 0 and throw an error if it is 0. In particular if you don't have any defined domains or networks (both fairly common scenarios) then this causes an error when you just pass the result of NumOfNetworks straight into ListNetworks. Backend drivers & QEMU seem to have no problem with maxNames being zero, so let's allow it. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

On Fri, Jun 22, 2007 at 06:01:01PM +0100, Richard W.M. Jones wrote:
It seems a bit pathological to check if maxNames <= 0 and throw an error if it is 0. In particular if you don't have any defined domains or networks (both fairly common scenarios) then this causes an error when you just pass the result of NumOfNetworks straight into ListNetworks. Backend drivers & QEMU seem to have no problem with maxNames being zero, so let's allow it.
hum, okay, it's true that other APIs manipulating arrays don't fail if the size given is 0 (e.g. strncpy). +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard
-
Richard W.M. Jones