[libvirt] [PATCH]: pass flags to all virDomain*DefParse* functions
On Thu, Dec 04, 2008 at 01:15:23PM +0100, Guido Günther wrote:
On Thu, Dec 04, 2008 at 10:56:25AM +0000, Daniel P. Berrange wrote:
On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido G?nther wrote:
On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote:
From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx@sigxcpu.org> Date: Tue, 25 Nov 2008 13:02:43 +0100 Subject: [PATCH] differentiate between active and inactive configs
by honoring the VIR_DOMAIN_XML_INACTIVE flag. O.k. to commit this part as a start so you can readily use it vor lxc?
ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the flag to the functions currently needed for qemu but if nobody objects I'd like to add them to:
virDomainDeviceDefParse virDomainDefParseString virDomainHostdevSubsysUsbDefParseXML virDomainDiskDefParseXML virDomainFSDefParseXML virDomainNetDefParseXML virDomainInputDefParseXML virDomainSoundDefParseXML virDomainHostdevDefParseXML virDomainChrDefParseXML
I'm about to release an intermediate 0.5.1 release with the bug and small improvement fixes since 0.5.0, I assume the more generic patch can wait after that, but that sounds right to me in principle. Attached patch adds a flag parameter to the above functions and passes VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in
On Thu, Dec 04, 2008 at 02:16:06PM +0100, Daniel Veillard wrote: this: * symmetric interfaces to the XML parsing functions (why has virDomainDefParseFile a flags argument while virDomainDefParseString hasn't) * other drivers can use this very easily (IIRC lxc has some use for it) otherwise there's not too much gain so I'm a bit undecided if this is actually necessary. -- Guido
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
by honoring the VIR_DOMAIN_XML_INACTIVE flag. O.k. to commit this part as a start so you can readily use it vor lxc?
ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the flag to the functions currently needed for qemu but if nobody objects I'd like to add them to:
virDomainDeviceDefParse virDomainDefParseString virDomainHostdevSubsysUsbDefParseXML virDomainDiskDefParseXML virDomainFSDefParseXML virDomainNetDefParseXML virDomainInputDefParseXML virDomainSoundDefParseXML virDomainHostdevDefParseXML virDomainChrDefParseXML
Attached patch adds a flag parameter to the above functions and passes VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in this:
* symmetric interfaces to the XML parsing functions (why has virDomainDefParseFile a flags argument while virDomainDefParseString hasn't) * other drivers can use this very easily (IIRC lxc has some use for it)
otherwise there's not too much gain so I'm a bit undecided if this is actually necessary.
ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Mon, Jan 05, 2009 at 10:27:03AM +0000, Daniel P. Berrange wrote:
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
> by honoring the VIR_DOMAIN_XML_INACTIVE flag. O.k. to commit this part as a start so you can readily use it vor lxc?
ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the flag to the functions currently needed for qemu but if nobody objects I'd like to add them to:
virDomainDeviceDefParse virDomainDefParseString virDomainHostdevSubsysUsbDefParseXML virDomainDiskDefParseXML virDomainFSDefParseXML virDomainNetDefParseXML virDomainInputDefParseXML virDomainSoundDefParseXML virDomainHostdevDefParseXML virDomainChrDefParseXML
Attached patch adds a flag parameter to the above functions and passes VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in this:
* symmetric interfaces to the XML parsing functions (why has virDomainDefParseFile a flags argument while virDomainDefParseString hasn't) * other drivers can use this very easily (IIRC lxc has some use for it)
otherwise there's not too much gain so I'm a bit undecided if this is actually necessary.
ACK
Sounds fine to me too, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Mon, Jan 05, 2009 at 03:21:35PM +0100, Daniel Veillard wrote:
On Mon, Jan 05, 2009 at 10:27:03AM +0000, Daniel P. Berrange wrote:
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
> > by honoring the VIR_DOMAIN_XML_INACTIVE flag. > O.k. to commit this part as a start so you can readily use it vor lxc?
ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the flag to the functions currently needed for qemu but if nobody objects I'd like to add them to:
virDomainDeviceDefParse virDomainDefParseString virDomainHostdevSubsysUsbDefParseXML virDomainDiskDefParseXML virDomainFSDefParseXML virDomainNetDefParseXML virDomainInputDefParseXML virDomainSoundDefParseXML virDomainHostdevDefParseXML virDomainChrDefParseXML
Attached patch adds a flag parameter to the above functions and passes VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in this:
* symmetric interfaces to the XML parsing functions (why has virDomainDefParseFile a flags argument while virDomainDefParseString hasn't) * other drivers can use this very easily (IIRC lxc has some use for it)
otherwise there's not too much gain so I'm a bit undecided if this is actually necessary.
ACK
Sounds fine to me too, Applied now. -- Guido
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Guido Günther