[libvirt] [PATCH] fix a error message and coding-style cleanup
Hi, This patch fixes a "copy&paste" error message in MemoryPeek() function of qemu driver. And while I am at it, this patch does some clean-up on coding style. Without this, my vim goes crazy while browsing the source. Please enforce the coding style (more or less similar to GNU style?) when merging. Thanks, Quynh # diffstat fix5.patch qemu_driver.c | 261 ++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 175 insertions(+), 86 deletions(-)
Hi, Quynh Would you separate a patch clean-up one and message one? These should be commited to separately. Thanks Atsushi SAKAI "Nguyen Anh Quynh" <aquynh@gmail.com> wrote:
Hi,
This patch fixes a "copy&paste" error message in MemoryPeek() function of qemu driver.
And while I am at it, this patch does some clean-up on coding style. Without this, my vim goes crazy while browsing the source.
Please enforce the coding style (more or less similar to GNU style?) when merging.
Thanks, Quynh
# diffstat fix5.patch qemu_driver.c | 261 ++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 175 insertions(+), 86 deletions(-)
On Fri, Aug 29, 2008 at 02:20:16PM +0900, Nguyen Anh Quynh wrote:
Hi,
This patch fixes a "copy&paste" error message in MemoryPeek() function of qemu driver.
Okay, can you provide a standalone patch ?
And while I am at it, this patch does some clean-up on coding style. Without this, my vim goes crazy while browsing the source.
Why ? i'm using vim, and don't see the problem, really
Please enforce the coding style (more or less similar to GNU style?) when merging.
See the HACKING file, the section about Code formatting (especially for new code) but please don't mix bug fixes and indentation changes in patches. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Fri, Aug 29, 2008 at 3:51 PM, Daniel Veillard <veillard@redhat.com> wrote:
On Fri, Aug 29, 2008 at 02:20:16PM +0900, Nguyen Anh Quynh wrote:
Hi,
This patch fixes a "copy&paste" error message in MemoryPeek() function of qemu driver.
Okay, can you provide a standalone patch ?
And while I am at it, this patch does some clean-up on coding style. Without this, my vim goes crazy while browsing the source.
Why ? i'm using vim, and don't see the problem, really
For example, "[[" goes crazy when you are inside a function with the opening "{" not at the first column. That is what I tried to fix. Thanks, Quynh
Here's just the fix to virDomainMemoryPeek. +1 from me. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
On Fri, Aug 29, 2008 at 01:51:34PM +0100, Richard W.M. Jones wrote:
Here's just the fix to virDomainMemoryPeek.
+1 from me.
sure +1, please push, and thanks to Nguyen :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Fri, Aug 29, 2008 at 04:23:20PM +0200, Daniel Veillard wrote:
On Fri, Aug 29, 2008 at 01:51:34PM +0100, Richard W.M. Jones wrote:
Here's just the fix to virDomainMemoryPeek.
+1 from me.
sure +1, please push, and thanks to Nguyen :-)
Okay I commited this ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (4)
-
Atsushi SAKAI -
Daniel Veillard -
Nguyen Anh Quynh -
Richard W.M. Jones