case for this change is in the iSCSI stuff; older versions of iscsiadm tools would return a failure when getting the session number, despite the command succeeding.

Index: src/storage_backend.c =================================================================== RCS file: /data/cvs/libvirt/src/storage_backend.c,v retrieving revision 1.14 diff -u -r1.14 storage_backend.c --- a/src/storage_backend.c 6 Jun 2008 11:09:57 -0000 1.14 +++ b/src/storage_backend.c 12 Jun 2008 13:19:39 -0000 @@ -352,7 +352,8 @@ const char **regex, int *nvars, virStorageBackendListVolRegexFunc func, - void *data) + void *data, + int *outexit)

{ int child = 0, fd = -1, exitstatus, err, failed = 1; FILE *list = NULL; @@ -487,12 +488,8 @@ return -1; } else { if (WIFEXITED(exitstatus)) { - if (WEXITSTATUS(exitstatus) != 0) { - virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("non-zero exit status from command %d"), - WEXITSTATUS(exitstatus)); - return -1; - } + if (outexit != NULL) + *outexit = WEXITSTATUS(exitstatus);