Hello, I noticed qemudDomainSetMemory() / qemudDomainSetVcpus() use the VIR_ERR_INTERNAL_ERROR error code when the caller attempts to set the mem/vcpus of an active domain. In this case, returning something like VIR_ERR_NO_SUPPORT would indicate that this is an invalid call - which would distinguish the error from a failure that occurred during the call. Is it possible to use such a return code to indicate what is supported by QEMU/KVM and what isn't? Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin(a)linux.vnet.ibm.com -- Libvir-list mailing list Libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Jun 05, 2008 at 03:38:46PM -0700, Kaitlin Rupert wrote: > Hello, > > I noticed qemudDomainSetMemory() / qemudDomainSetVcpus() use the > VIR_ERR_INTERNAL_ERROR error code when the caller attempts to set the > mem/vcpus of an active domain. > > In this case, returning something like VIR_ERR_NO_SUPPORT would indicate > that this is an invalid call - which would distinguish the error from a > failure that occurred during the call. Yes, that would be a better choice in this scenario. Patches welcomed to changed this :-) Dan.