[libvirt] [PATCH] qemu: fix crash in qemuOpen

If the path part of connection URI is not present, cfg is used unitialized. https://bugzilla.redhat.com/show_bug.cgi?id=950855 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c0d7d1..0d41e39 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1025,16 +1025,16 @@ static virDrvOpenStatus qemuOpen(virConnectPtr conn, _("qemu state driver is not active")); goto cleanup; } + cfg = virQEMUDriverGetConfig(qemu_driver); if (conn->uri->path == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, _("no QEMU URI path given, try %s"), cfg->uri); goto cleanup; } - cfg = virQEMUDriverGetConfig(qemu_driver); if (cfg->privileged) { if (STRNEQ(conn->uri->path, "/system") && STRNEQ(conn->uri->path, "/session")) { virReportError(VIR_ERR_INTERNAL_ERROR, -- 1.8.1.5

On 04/11/13 11:42, Ján Tomko wrote:
If the path part of connection URI is not present, cfg is used unitialized.
https://bugzilla.redhat.com/show_bug.cgi?id=950855 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK. Peter

On 04/11/2013 11:48 AM, Peter Krempa wrote:
On 04/11/13 11:42, Ján Tomko wrote:
If the path part of connection URI is not present, cfg is used unitialized.
https://bugzilla.redhat.com/show_bug.cgi?id=950855 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Peter
Thanks, pushed. Jan
participants (2)
-
Ján Tomko
-
Peter Krempa