7:49 a.m.
These patches implement some rather trivial missing calls in the bhyve driver.
Since the bhyve connection (Interaction through /dev/vmm as well as the bhyveload,
bhyvectl user-space tools) is local, encryption is not applicable, but the connection is
seen as not prone to eavesdropping.
Fabian Freyer (2):
bhyve: Implement virConnectIsEncrypted
bhyve: implement virConnectIsSecure
src/bhyve/bhyve_driver.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
--
2.7.2
7:49 a.m.
New subject: [libvirt] [PATCH 1/2] bhyve: Implement virConnectIsEncrypted
Being a local connection, bhyve does not support encryption. Therefore
trivially return 0.
---
src/bhyve/bhyve_driver.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 8b41f7a..43c7183 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -1522,6 +1522,13 @@ static int bhyveConnectIsAlive(virConnectPtr conn
ATTRIBUTE_UNUSED)
return 1;
}
+static int
+bhyveConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED)
+{
+ /* Not encrypted, but remote driver takes care of that */
+ return 0;
+}
+
static virHypervisorDriver bhyveHypervisorDriver = {
.name = "bhyve",
.connectOpen = bhyveConnectOpen, /* 1.2.2 */
@@ -1573,6 +1580,7 @@ static virHypervisorDriver bhyveHypervisorDriver = {
.domainHasManagedSaveImage = bhyveDomainHasManagedSaveImage, /* 1.2.13 */
.connectGetType = bhyveConnectGetType, /* 1.3.5 */
.connectIsAlive = bhyveConnectIsAlive, /* 1.3.5 */
+ .connectIsEncrypted = bhyveConnectIsEncrypted, /* 1.3.5 */
};
--
2.7.2
7:49 a.m.
New subject: [libvirt] [PATCH 2/2] bhyve: implement virConnectIsSecure
Trivially return 1, since bhyve is considered a local connection that
should not be vulnerable to eavesdropping.
---
src/bhyve/bhyve_driver.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 43c7183..441c666 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -1523,6 +1523,13 @@ static int bhyveConnectIsAlive(virConnectPtr conn
ATTRIBUTE_UNUSED)
}
static int
+bhyveConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED)
+{
+ /* Trivially secure, since always inside the daemon */
+ return 1;
+}
+
+static int
bhyveConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED)
{
/* Not encrypted, but remote driver takes care of that */
@@ -1580,6 +1587,7 @@ static virHypervisorDriver bhyveHypervisorDriver = {
.domainHasManagedSaveImage = bhyveDomainHasManagedSaveImage, /* 1.2.13 */
.connectGetType = bhyveConnectGetType, /* 1.3.5 */
.connectIsAlive = bhyveConnectIsAlive, /* 1.3.5 */
+ .connectIsSecure = bhyveConnectIsSecure, /* 1.3.5 */
.connectIsEncrypted = bhyveConnectIsEncrypted, /* 1.3.5 */
};
--
2.7.2
12:32 p.m.
Fabian Freyer wrote:
These patches implement some rather trivial missing calls in the
bhyve driver.
Since the bhyve connection (Interaction through /dev/vmm as well as the bhyveload,
bhyvectl user-space tools) is local, encryption is not applicable, but the connection is
seen as not prone to eavesdropping.
Fabian Freyer (2):
bhyve: Implement virConnectIsEncrypted
bhyve: implement virConnectIsSecure
src/bhyve/bhyve_driver.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
ACKed and pushed the series.
Roman Bogorodskiy
3108
days inactive
3108
days old
3 comments
2 participants
participants (2)
-
Fabian Freyer -
Roman Bogorodskiy