On 04/25/2011 03:14 PM, David Streibl wrote:

Hello,

as part of my student project I am working on simple web interface which would support multiple virtualisation platforms. This of course led me to libvirt and libvirt-php more specificly.

David, this is fine. You can do it, of course and in fact this would be great for you to get to know the libvirt-php code and API. I'll comment it inline.

Right now I'm using modfied code of exapme Libvirt class and the plan is: - add phpdoc - refactor it to match libvirt convetion (get_domain_someting -> dmain_get_something) - split Libvirt to subclasses for domain, connection, network, storage (not completly sure if it is good idea) - add few unit tests (dont know about time and usefulness of this)

Would it be welcomed if I send to whole think or even parts of it as patches to libvirt-php/example?

This would be all great however could you please wait for a week or so? I'm doing the development in my spare time to introduce many new features to both bindings and the class so you can refactor after that. Could you please wait a week or two? Michal -- Michal Novotny <minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat