4:08 a.m.
Hi exports,
I tried to contribute a patch to fix a bug, following the contributor guidelines
on http://libvirt.org/hacking.html.
After I do the 'git send-email' operation and edit the email content, It
returns:
Who should the emails appear to be from? [Guan Qiang
<hzguanqiang(a)corp.netease.com>]
Emails will be sent from: Guan Qiang <hzguanqiang(a)corp.netease.com>
Message-ID to be used as In-Reply-To for the first email?
(mbox) Adding cc: Guan Qiang <hzguanqiang(a)corp.netease.com> from line 'From:
Guan Qiang <hzguanqiang(a)corp.netease.com>'
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
To: libvir-list(a)redhat.com
Cc: Guan Qiang <hzguanqiang(a)corp.netease.com>
Subject: [PATCH]Fix a PyList usage mistake
Date: Thu, 29 Aug 2013 13:41:38 +0800
Message-Id: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
X-Mailer: git-send-email 1.7.10.4
The Cc list above has been expanded by additional
addresses found in the patch commit message. By default
send-email prompts before sending whenever this occurs.
This behavior is controlled by the sendemail.confirm
configuration setting.
For additional information, run 'git send-email --help'.
To retain the current behavior, but squelch this message,
run 'git config --global sendemail.confirm auto'.
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
OK. Log says:
Sendmail: /usr/sbin/sendmail -i libvir-list(a)redhat.com hzguanqiang(a)corp.netease.com
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
To: libvir-list(a)redhat.com
Cc: Guan Qiang <hzguanqiang(a)corp.netease.com>
Subject: [PATCH]Fix a PyList usage mistake
Date: Thu, 29 Aug 2013 13:41:38 +0800
Message-Id: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
X-Mailer: git-send-email 1.7.10.4
Result: OK
(mbox) Adding cc: Guan Qiang <hzguanqiang(a)corp.netease.com> from line 'From:
Guan Qiang <hzguanqiang(a)corp.netease.com>'
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
To: libvir-list(a)redhat.com
Cc: Guan Qiang <hzguanqiang(a)corp.netease.com>
Subject: [PATCH] Fix a PyList usage mistake
Date: Thu, 29 Aug 2013 13:41:39 +0800
Message-Id: <1377754899-29698-2-git-send-email-hzguanqiang(a)corp.netease.com>
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
References: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
OK. Log says:
Sendmail: /usr/sbin/sendmail -i libvir-list(a)redhat.com hzguanqiang(a)corp.netease.com
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
To: libvir-list(a)redhat.com
Cc: Guan Qiang <hzguanqiang(a)corp.netease.com>
Subject: [PATCH] Fix a PyList usage mistake
Date: Thu, 29 Aug 2013 13:41:39 +0800
Message-Id: <1377754899-29698-2-git-send-email-hzguanqiang(a)corp.netease.com>
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
References: <1377754899-29698-1-git-send-email-hzguanqiang(a)corp.netease.com>
Result: OK
Does this mean everything is done? Or do I still need to do other thing?
Since I do this operation, It had passed three hours and I still can't find my patch
email on 'libvir-list'.
Really appreciate your advice, Thanks.
------------------
Best regards!
GuanQiang
2013-08-29
4:45 a.m.
New subject: [libvirt] Question about how to contribute patches
On Thu, Aug 29, 2013 at 05:08:04PM +0800, hzguanqiang(a)corp.netease.com wrote:
Hi exports,
I tried to contribute a patch to fix a bug, following the contributor guidelines
on http://libvirt.org/hacking.html.
After I do the 'git send-email' operation and edit the email content, It returns:
[snip]
Does this mean everything is done? Or do I still need to do other
thing?
Since I do this operation, It had passed three hours and I still can't
find my patch email on 'libvir-list'.
Based on your logs it looks like git sent the emails to the smtp server
on your local machine. Presumably you don't have that setup to actually
deliver the mail ?
You probably want to tell git to use your company's primary SMTP server
for delivery.
I use a simple wrapper script for git send-mail
$ cat ~/bin/git-spam
#!/bin/sh
dohelp() {
echo "syntax: $0 TO-ADDR REV-LIST"
}
if [ -z "$2" ]; then
dohelp;
exit 1
fi
TO=$1
REV=$2
shift
shift
git send-email --cover-letter --annotate --to "$TO"
--smtp-server=smtp.corp.redhat.com --no-chain-reply-to $REV "$@"
Replace 'smtp.corp.redhat.com' with your own company's SMTP server
address.
Assuming, I'm on a branch and have a series of patches to send, then I use
it as follows
git-spam libvir-list(a)redhat.com master..
If I only want to send one single patch then I would use
git-spam libvir-list(a)redhat.com -1 --no-cover-letter
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
4:54 a.m.
New subject: [libvirt] Question about how to contribute patches
On 08/29/2013 05:08 PM, hzguanqiang(a)corp.netease.com wrote:
Hi exports,
I tried to contribute a patch to fix a bug, following the contributor guidelines
on http://libvirt.org/hacking.html.
Do you have below context in you libvirt/.git/config?
[sendemail]
from = Guan Qiang <hzguanqiang(a)corp.netease.com>
smtpuser = Your email address
smtppass = Your password
smtpserver = Your smtpserver address
smtpencryption = plain
6:07 a.m.
New subject: [libvirt] Question about how to contribute patches
Thanks for everyone. It succeed this time. Daniel's script is very convenient.
On 2013-08-29 17:54 , Gao feng wrote:
On 08/29/2013 05:08 PM, hzguanqiang(a)corp.netease.com wrote:
Hi exports,
I tried to contribute a patch to fix a bug, following the contributor guidelines
on http://libvirt.org/hacking.html.
Do you have below context in you libvirt/.git/config?
[sendemail]
from = Guan Qiang <hzguanqiang(a)corp.netease.com>
smtpuser = Your email address
smtppass = Your password
smtpserver = Your smtpserver address
smtpencryption = plain
------------------
Best regards!
GuanQiang
19:06:18
6:43 a.m.
New subject: [libvirt] Question about how to contribute patches
On 08/29/2013 03:08 AM, hzguanqiang(a)corp.netease.com wrote:
Hi exports,
I tried to contribute a patch to fix a bug, following the contributor guidelines
on http://libvirt.org/hacking.html.
After I do the 'git send-email' operation and edit the email content, It
returns:
Does this mean everything is done? Or do I still need to do other thing?
I recommend that you FIRST use 'git send-email' to send mail to
yourself, and debug that it works. Once you know git send-email can
actually send mail to yourself, only then would I update the config to
try and send to the list.
Since I do this operation, It had passed three hours and I still
can't find my patch email on 'libvir-list'.
Also, remember that the list has a human moderation in the loop for all
first time posts (whether you are subscribed or not); depending on
whether your git configuration is slightly different than your normal
mail, your patches may be stuck in a moderation queue; it's always worth
waiting 24 hours rather than just three before asking if mail was lost.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4103
days inactive
4103
days old
4 comments
4 participants
participants (4)
-
Daniel P. Berrange -
Eric Blake -
Gao feng -
hzguanqiang＠corp.netease.com