[libvirt] [PATCH] Cleanup when Storage Pool Create fails.
When libvirt fails to create a storage pool (e.g. a disk pool does not have a partition table), the failed storage pool is not cleaned up correctly and is not possible to re-create the pool again. This attached patch addresses this problem. /Henrik
On Mon, Jun 22, 2009 at 09:27:32AM +0200, Henrik Persson E wrote:
When libvirt fails to create a storage pool (e.g. a disk pool does not have a partition table), the failed storage pool is not cleaned up correctly and is not possible to re-create the pool again. This attached patch addresses this problem.
Sigh, this was reported a few weeks back and I could hav sworn we fixed it but I guess we forgot to apply the patch. ACK to your patch. BTW, could you check that your mail client sends patch attachments with a mime type of text/plain rather tha application/octet-stream, as this makes it easier to reply & quote text. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Mon, Jun 22, 2009 at 09:27:32AM +0200, Henrik Persson E wrote:
When libvirt fails to create a storage pool (e.g. a disk pool does not have a partition table), the failed storage pool is not cleaned up correctly and is not possible to re-create the pool again. This attached patch addresses this problem.
Looks right, applied and commited, thanks ! Daniel P.S.: since your patch was against 0.6.1, I really suggests to update to 0.6.4 if possible, we really fixed a lot of bug since that version. -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Henrik Persson E