[libvirt] [jenkins-ci PATCH 0/2] Add glibc-langpack-en to the mappings & to the base project

As done for locales, lets also add glibc-langpack-en to the mappings and to the base project. The reasoning for that is that (at least) osinfo-db tests set the locale to en_US causing errors like: 1215 INTERNALERROR> Traceback (most recent call last): 1216 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 96, in wrap_session 1217 INTERNALERROR> config._do_configure() 1218 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 922, in _do_configure 1219 INTERNALERROR> self.hook.pytest_configure.call_historic(kwargs=dict(config=self)) 1220 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 628, in call_historic 1221 INTERNALERROR> res = self._hookexec(self, self._nonwrappers + self._wrappers, kwargs) 1222 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec 1223 INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs) 1224 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda> 1225 INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'), 1226 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall 1227 INTERNALERROR> return outcome.get_result() 1228 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result 1229 INTERNALERROR> raise ex[1].with_traceback(ex[2]) 1230 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall 1231 INTERNALERROR> res = hook_impl.function(*args) 1232 INTERNALERROR> File "/builds/fidencio/osinfo-db/tests/conftest.py", line 27, in pytest_configure 1233 INTERNALERROR> locale.setlocale(locale.LC_CTYPE, 'en_US.UTF-8') 1234 INTERNALERROR> File "/usr/lib64/python3.6/locale.py", line 598, in setlocale 1235 INTERNALERROR> return _setlocale(category, locale) 1236 INTERNALERROR> locale.Error: unsupported locale setting 1237 make: *** [../Makefile:124: check] Error 3 Fabiano Fidêncio (2): mappings: Add glibc-langpack-en guests: Add glibc-langpack-en to the base project guests/vars/mappings.yml | 5 +++++ guests/vars/projects/base.yml | 1 + 2 files changed, 6 insertions(+) -- 2.23.0

Unfortunately, due to really stripped CentOS 8 containers, we have to explicitly add glibc-langpack-en package in order to fulfil the osinfo-db tests needs. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/mappings.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 07ab6db..68664a0 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -189,6 +189,11 @@ mappings: rpm: glibc-devel cross-policy-deb: foreign + glibc-langpack-en: + rpm: glibc-langpack-en + CentOS7: + OpenSUSE: + glibc-static: deb: libc6-dev rpm: glibc-static -- 2.23.0

On Thu, 2019-12-12 at 11:19 +0100, Fabiano Fidêncio wrote:
Unfortunately, due to really stripped CentOS 8 containers, we have to explicitly add glibc-langpack-en package in order to fulfil the osinfo-db tests needs.
s/fulfil/fulfill/ Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization

glibc-langpack-en is present on all supported Fedoras and CentOS 8. It's needed in order to set a locale to en_US, which is done as part of osinfo-db tests (at least). Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/projects/base.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 29c10b4..9ebf249 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -14,6 +14,7 @@ packages: - gettext - git - glibc + - glibc-langpack-en - libtool - libtoolize - locales -- 2.23.0

On Thu, 2019-12-12 at 11:19 +0100, Fabiano Fidêncio wrote:
glibc-langpack-en is present on all supported Fedoras and CentOS 8. It's needed in order to set a locale to en_US, which is done as part of osinfo-db tests (at least).
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/projects/base.yml | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani
-
Fabiano Fidêncio