[libvirt] [PATCH 2/14] Add build support
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
This patch adds build support for the network filtering framework.
Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>
Attachments:
- add_build_support.diff (text/x-patch — 6.3 KB)
On 03/18/2010 09:16 AM, Stefan Berger wrote:
This patch adds build support for the network filtering framework.
Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>
Some nits, but I'll let others more familiar with the process of API
expansion give an actual ack/nak review.
+NWFILTER_CONF_SOURCES = \
+ $(NWFILTER_PARAM_CONF_SOURCES) \
+ conf/nwfilter_conf.c conf/nwfilter_conf.h
What's with the mix between tabs and spaces before the \?
Moreover, it seems a bit odd to hook up the Makefile support in 2/14
when the new files don't exist until 12/14. But I guess that's okay as
long as the automake conditional that enables this block of code doesn't
trigger until the files exist.
fi
+if test "$with_nwfilter" = "yes" ; then
+ AC_DEFINE_UNQUOTED([WITH_NWFILTER], 1, [whether local network filter management driver
is available])
+fi
You can use AC_DEFINE instead of AC_DEFINE_UNQUOTED here, since you
aren't doing any shell expansion on either WITH_NWFILTER or 1.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Eric Blake <eblake(a)redhat.com> wrote on 03/18/2010 03:11:09 PM:
On 03/18/2010 09:16 AM, Stefan Berger wrote:
> This patch adds build support for the network filtering framework.
>
> Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>
>
Some nits, but I'll let others more familiar with the process of API
expansion give an actual ack/nak review.
> +NWFILTER_CONF_SOURCES = \
> + $(NWFILTER_PARAM_CONF_SOURCES) \
> + conf/nwfilter_conf.c conf/nwfilter_conf.h
What's with the mix between tabs and spaces before the \?
Fixed.
Moreover, it seems a bit odd to hook up the Makefile support in 2/14
when the new files don't exist until 12/14. But I guess that's okay as
long as the automake conditional that enables this block of code doesn't
trigger until the files exist.
All patches up to 12/14 are necessary for anything to work. It's also
possible that an earlier patch has a code-dependency on a later one, so
ordering isn't quite that simple...
> fi
> +if test "$with_nwfilter" = "yes" ; then
> + AC_DEFINE_UNQUOTED([WITH_NWFILTER], 1, [whether local network
filter management driver is available])
> +fi
You can use AC_DEFINE instead of AC_DEFINE_UNQUOTED here, since you
aren't doing any shell expansion on either WITH_NWFILTER or 1.
Ok,
Thanks and regards,
Stefan
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
[attachment "signature.asc" deleted by Stefan Berger/Watson/IBM]
5363
days inactive
5363
days old
2 comments
2 participants
tags (0)
participants (2)
-
Eric Blake -
Stefan Berger