[Libvir] [PATCH] Add error message to virsh setmem/setmaxmem

Hi Virsh setmem/setmaxmem doesn't output an error message when an invalid value is set to "bytes". This patch outputs an error message, when an invalid value is set as "bytes" of virsh setmem/setmaxmem. Signed-off-by: Masayuki Sunou <fj1826dm@aa.jp.fujitsu.com> Thanks, Masayuki Sunou. Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.66 diff -u -p -r1.66 virsh.c --- src/virsh.c 19 Mar 2007 14:20:30 -0000 1.66 +++ src/virsh.c 19 Mar 2007 23:29:14 -0000 @@ -1461,6 +1461,7 @@ cmdSetmem(vshControl * ctl, vshCmd * cmd bytes = vshCommandOptInt(cmd, "bytes", &bytes); if (bytes <= 0) { virDomainFree(dom); + vshError(ctl, FALSE, _("Invalid value of \"bytes\"")); return FALSE; } @@ -1504,6 +1505,7 @@ cmdSetmaxmem(vshControl * ctl, vshCmd * bytes = vshCommandOptInt(cmd, "bytes", &bytes); if (bytes <= 0) { virDomainFree(dom); + vshError(ctl, FALSE, _("Invalid value of \"bytes\"")); return FALSE; }

On Tue, Mar 20, 2007 at 08:35:08AM +0900, Masayuki Sunou wrote:
Hi
Virsh setmem/setmaxmem doesn't output an error message when an invalid value is set to "bytes".
This patch outputs an error message, when an invalid value is set as "bytes" of virsh setmem/setmaxmem.
Okay, makes sense, but I changed the message to vshError(ctl, FALSE, _("Invalid value of %d for memory size"), bytes); in order to provide more contextual informations, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard
-
Masayuki Sunou