[libvirt] [PATCH] news: Add modern ivshmem support
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- docs/news.html.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/news.html.in b/docs/news.html.in index fca1e29d043c..473c2ead13b4 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -22,6 +22,9 @@ List user-visible changes instead of single commits for a better high-level overview of differences between libvirt releases </li> + <li>The shmem device can now utilize qemu's ivshmem-plain and + ivshmem-doorbell, more modern versions of ivshmem + </li> <li>Various bug fixes and improvements</li> </ul> -- 2.10.2
On Mon, 2016-11-21 at 13:26 +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- docs/news.html.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/news.html.in b/docs/news.html.in index fca1e29d043c..473c2ead13b4 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -22,6 +22,9 @@ List user-visible changes instead of single commits for a better high-level overview of differences between libvirt releases </li> + <li>The shmem device can now utilize qemu's ivshmem-plain and + ivshmem-doorbell, more modern versions of ivshmem + </li> <li>Various bug fixes and improvements</li> </ul>
I was thinking more of along the lines of One-line summary Couple of sentences that actually explain the change How about this instead? <li>Add support for additional shmem models<br/> The shmem device can now utilize QEMU's ivshmem-plain and ivshmem-doorbell, more modern versions of ivshmem </li> I made QEMU uppercase while at it ;) -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Nov 21, 2016 at 04:15:44PM +0100, Andrea Bolognani wrote:
On Mon, 2016-11-21 at 13:26 +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- docs/news.html.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/news.html.in b/docs/news.html.in index fca1e29d043c..473c2ead13b4 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -22,6 +22,9 @@ List user-visible changes instead of single commits for a better high-level overview of differences between libvirt releases </li> + <li>The shmem device can now utilize qemu's ivshmem-plain and + ivshmem-doorbell, more modern versions of ivshmem + </li> <li>Various bug fixes and improvements</li> </ul>
I was thinking more of along the lines of
One-line summary Couple of sentences that actually explain the change
How about this instead?
<li>Add support for additional shmem models<br/> The shmem device can now utilize QEMU's ivshmem-plain and ivshmem-doorbell, more modern versions of ivshmem </li>
I made QEMU uppercase while at it ;)
Sure, but in this case you want to separate the summary from the explanation. Either using <dl/> instead of <ul/> or at least making the one line summary bold or something. I'm afraid, though, that the multiline requirement will drive even more people away from writing anything in the news file. But as you said, we can do style changes later on. Does that mean ACK on your version? =D
-- Andrea Bolognani / Red Hat / Virtualization
On Mon, 2016-11-21 at 22:20 +0100, Martin Kletzander wrote:
+ <li>The shmem device can now utilize qemu's ivshmem-plain and + ivshmem-doorbell, more modern versions of ivshmem + </li> I was thinking more of along the lines of One-line summary Couple of sentences that actually explain the change How about this instead? <li>Add support for additional shmem models<br/> The shmem device can now utilize QEMU's ivshmem-plain and ivshmem-doorbell, more modern versions of ivshmem </li> I made QEMU uppercase while at it ;) Sure, but in this case you want to separate the summary from the explanation.
That's what the <br/> is supposed to do. Not the most elegant solution, I agree.
Either using <dl/> instead of <ul/> or at least making the one line summary bold or something.
We don't want the HTML version to be a complete bold-fest, but the <dl> idea is definitely worth investigating. Do you feel like looking into that? Otherwise I'll do it, but be warned that it might be a while before I can bring myself to touch XSLT again :S
I'm afraid, though, that the multiline requirement will drive even more people away from writing anything in the news file.
Mh, I didn't consider that. You might be right... On the other hand, it's something that can easily be addressed during review, and if someone has already provided a 90% good NEWS file entry they probably won't back out just because of the need for some minor tweaking.
But as you said, we can do style changes later on.
We certainly can, and quite probably will ;)
Does that mean ACK on your version? =D
Well, it's been pushed already ;) -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Martin Kletzander