[libvirt] [PATCH] free cpumask of vcpupinDef

cpumask doesn't get freed when vcpupinDef being freed, this leaks memory. --- src/conf/domain_conf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1de4c7a..7b6b044 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -858,6 +858,7 @@ virDomainVcpupinDefFree(virDomainVcpupinDefPtr *def, return; for(i = 0; i < nvcpupin; i++) { + VIR_FREE(def[i]->cpumask); VIR_FREE(def[i]); } -- 1.7.3.1

于 2011年04月14日 11:34, Hu Tao 写道:
cpumask doesn't get freed when vcpupinDef being freed, this leaks memory. --- src/conf/domain_conf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1de4c7a..7b6b044 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -858,6 +858,7 @@ virDomainVcpupinDefFree(virDomainVcpupinDefPtr *def, return;
for(i = 0; i< nvcpupin; i++) { + VIR_FREE(def[i]->cpumask); VIR_FREE(def[i]); }
Oh, Introduced by me, thanks for the fix, ACK, :) Regards Osier

On 04/14/2011 12:50 AM, Osier Yang wrote:
于 2011年04月14日 11:34, Hu Tao 写道:
cpumask doesn't get freed when vcpupinDef being freed, this leaks memory. --- src/conf/domain_conf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1de4c7a..7b6b044 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -858,6 +858,7 @@ virDomainVcpupinDefFree(virDomainVcpupinDefPtr *def, return;
for(i = 0; i< nvcpupin; i++) { + VIR_FREE(def[i]->cpumask); VIR_FREE(def[i]); }
Oh, Introduced by me, thanks for the fix, ACK, :)
Pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
Eric Blake
-
Hu Tao
-
Osier Yang