[libvirt] [PATCH] Document behavior of compat when creating qcow2 volumes
Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation. Before, the option was omitted from qemu-img command line and the qemu-img default was used. Now we always specify the compat value and the default is 0.10. Reported by Christophe Fergeau https://bugzilla.gnome.org/show_bug.cgi?id=746660#c4 --- docs/formatstorage.html.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index d2e2bb8..9c7b1bd 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -588,8 +588,9 @@ <code>type='qcow2'</code> volumes. Valid values are <code>0.10</code> and <code>1.1</code> so far, specifying QEMU version the images should be compatible with. If the <code>feature</code> element is present, - 1.1 is used. If omitted, qemu-img default is used. - <span class="since">Since 1.1.0</span> + 1.1 is used. + <span class="since">Since 1.1.0</span> If omitted, 0.10 is used. + <span class="since">Since 1.1.2</span> </dd> <dt><code>nocow</code></dt> <dd>Turn off COW of the newly created volume. So far, this is only valid -- 2.0.5
On Tue, Mar 24, 2015 at 17:21:26 +0100, Ján Tomko wrote:
Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation.
Before, the option was omitted from qemu-img command line and the qemu-img default was used. Now we always specify the compat value and the default is 0.10.
Reported by Christophe Fergeau https://bugzilla.gnome.org/show_bug.cgi?id=746660#c4 --- docs/formatstorage.html.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index d2e2bb8..9c7b1bd 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -588,8 +588,9 @@ <code>type='qcow2'</code> volumes. Valid values are <code>0.10</code> and <code>1.1</code> so far, specifying QEMU version the images should be compatible with. If the <code>feature</code> element is present, - 1.1 is used. If omitted, qemu-img default is used. - <span class="since">Since 1.1.0</span> + 1.1 is used. + <span class="since">Since 1.1.0</span> If omitted, 0.10 is used. + <span class="since">Since 1.1.2</span>
You could explicitly state that previously the qemu-img default was used.
</dd> <dt><code>nocow</code></dt> <dd>Turn off COW of the newly created volume. So far, this is only valida
ACK, Peter
On Tue, Mar 24, 2015 at 05:43:41PM +0100, Peter Krempa wrote:
On Tue, Mar 24, 2015 at 17:21:26 +0100, Ján Tomko wrote:
Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation.
Before, the option was omitted from qemu-img command line and the qemu-img default was used. Now we always specify the compat value and the default is 0.10.
Reported by Christophe Fergeau https://bugzilla.gnome.org/show_bug.cgi?id=746660#c4 --- docs/formatstorage.html.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index d2e2bb8..9c7b1bd 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -588,8 +588,9 @@ <code>type='qcow2'</code> volumes. Valid values are <code>0.10</code> and <code>1.1</code> so far, specifying QEMU version the images should be compatible with. If the <code>feature</code> element is present, - 1.1 is used. If omitted, qemu-img default is used. - <span class="since">Since 1.1.0</span> + 1.1 is used. + <span class="since">Since 1.1.0</span> If omitted, 0.10 is used. + <span class="since">Since 1.1.2</span>
You could explicitly state that previously the qemu-img default was used.
I didn't want to clutter the documentation by mentioning behavior that was only there for two releases over a year ago. The version gap there should be enough for someone using libvirt 1.1.0 that the behavior with the missing attribute is unspecified.
</dd> <dt><code>nocow</code></dt> <dd>Turn off COW of the newly created volume. So far, this is only valida
ACK,
Thanks, pushed. Jan
participants (2)
-
Ján Tomko -
Peter Krempa