[libvirt] Some close/fclose/closedir calls are missing

While debugging something that looked like an file descriptor leak, we (Maximilian Wilhelm and me) found some places where close/fclose/closedir calls are missing, mostly in error handling if-branches. See attached patch. Max and Matthias

Matthias Bolte wrote:
While debugging something that looked like an file descriptor leak, we (Maximilian Wilhelm and me) found some places where close/fclose/closedir calls are missing, mostly in error handling if-branches.
See attached patch.
Max and Matthias
Nice catches. ACK -- Chris Lalancette

On Sat, Sep 05, 2009 at 02:44:44AM +0200, Matthias Bolte wrote:
While debugging something that looked like an file descriptor leak, we (Maximilian Wilhelm and me) found some places where close/fclose/closedir calls are missing, mostly in error handling if-branches.
See attached patch.
Yep good catch ! Applying and commiting Just one little thing, could you tell gmail that your attachment are text/plain instead of applica/mbox so that they can be viewed directly ? thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Chris Lalancette
-
Daniel Veillard
-
Matthias Bolte