On Sun, May 05, 2013 at 10:51:35AM +0200, Stefan Majer wrote:

Hi,

back in January 2013 Claudio Bley submit a series of patches [1] to enable event support to libvirt-java. There was no response on his work and they didn't get merged. Probably because there was not enough need out there.

But i would like to see this merged and had some conversion with Claudio the last 2 weeks, i tested his work and can confirm it works. I have some small additional, mostly cosmetic patches on top, but i would like to get feedback from the list if there is a chance to get them merged.

So any comments and suggestions welcome !

Well, if you think they are good, please give a slightly more detailed review, since libvirt-java doesn't have that many reviewers, that's probably sufficient. Claudio has commit write for that repository he can push if you give him a review, jump in, it is not that hard :-) Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/