Re: [libvirt] [PATCH v2 1/2] util/viriptables: add/remove rules that short-circuit masquerading
On 09/23/13 16:31, Laine Stump wrote:
On 09/23/2013 10:05 AM, Laszlo Ersek wrote:
> +/* Don't masquerade traffic coming from the network
associated with the bridge
> + * if said traffic targets @destaddr.
> + */
> +static int
> +iptablesForwardDontMasquerade(virSocketAddr *netaddr,
> + unsigned int prefix,
> + const char *physdev,
> + const char *destaddr,
> + int action)
The name of the function is a bit troublesome to me though, since
it's
actually being used to setup rules for packets that *aren't* being
forwarded (and the rules aren't going into the FORWARD table). How about
naming it "iptablesDontMasquerade"? Some other name?
Will follow your suggestion in v3. Thank you!
Laszlo