Re: [libvirt] [PATCH] util: fixing wrong comparison inside virStoragePermsCopy().
On Thu, Jun 01, 2017 at 22:58:06 -0300, Julio Faracco wrote:
VIR_STRDUP returns -1 if the string copy was not successful. So, the
current
comparison/logic is throwing an error when VIR_STRDUP() returns 1. Only when
source is NULL, it is considering as a success which is not right.
Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com>
---
src/util/virstoragefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK, I'll rewrap the commit message and push this shortly.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)