On 07/15/2014 07:25 AM, Peter Krempa wrote:
Use the backing store parser to properly create the information about a volume's backing store. Unfortunately as the storage driver isn't perpared to allow volumes backed by networked filesystems add a
s/perpared/prepared/
workaroud that will avoid changing the XML output.
s/workaroud/workaround/
--- src/storage/storage_backend_fs.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
+ /* XXX: Remote storage doesn't play nicely with volumes backed by + * remote storage. To avoid trouble, just fake the ou */
Incomplete thought?
+ if (target->backingStore->format == VIR_STORAGE_FILE_AUTO) { - if (!virStorageIsFile(target->backingStore->path) || - (rc = virStorageFileProbeFormat(target->backingStore->path, + if ((rc = virStorageFileProbeFormat(target->backingStore->path, -1, -1)) < 0) {
Indentation is off. ACK with those fixes. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org