On 12/17/2013 01:42 PM, Eric Blake wrote:
On 12/17/2013 10:04 AM, Wout Mertens wrote:
From: Wout Mertens <Wout.Mertens@gmail.com>
vmx/vmx.c ignores the transient attribute on the disk xml format. This patch adds a 1-1 relationship between it and [disk].mode = "independent-nonpersistent".
The other modes are ignored as before. It works in my testing.
https://bugzilla.redhat.com/show_bug.cgi?id=1044023
--- src/vmx/vmx.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)
Congrats on your first libvirt patch. It failed 'make syntax-check':
But I don't mind fixing those on a first-time submission.
Oh, I spoke too soon. It also fails 'make check': ../build-aux/test-driver: line 95: 19280 Segmentation fault (core dumped) "$@" > $log_file 2>&1 FAIL: vmx2xmltest Not a good sign. I can still try and fix that before pushing, but for now your patch is not upstream. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org