Re: [libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults
On Wed, Aug 22, 2018 at 11:44:17AM +0200, Andrea Bolognani wrote:
Instead of defining a default and overriding it on a
case-by-case basis, always define archive_format at the
project level.
This adds a bit of duplication, but it's consistent with
how we define other metadata for projects and it will
help us out later.
How is it going to help us later? So here you move something which is perfectly
fine to have in defaults and override it only when necessary and in the
following patch you're making a preparation changes for essentially the
opposite of this - moving autogen_args and similar to defaults (not that any
template needs to override these at the moment, but I'm getting confused by the
consistency you talk about).
I think this patch should be dropped.
Erik