Re: [libvirt] [PATCH v2] glibcompat: Reimplement g_strdup_printf() and g_strdup_vprintf()

On Fri, Oct 18, 2019 at 11:49:05 +0200, Michal Privoznik wrote: > These functions don't really abort() on OOM. The fix was merged > upstream, but not in the minimal version we require. Provide our > own implementation which can be removed once we bump the minimal > version. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > > v2 of: > > https://www.redhat.com/archives/libvir-list/2019-October/msg01153.html > > diff to v1: > - moved the code to src/utils/glibcompat.c > > src/internal.h | 1 + > src/libvirt_private.syms | 5 +++++ > src/util/Makefile.inc.am | 2 ++ > src/util/glibcompat.c | 48 ++++++++++++++++++++++++++++++++++++++++ > src/util/glibcompat.h | 31 ++++++++++++++++++++++++++ > 5 files changed, 87 insertions(+) > create mode 100644 src/util/glibcompat.c > create mode 100644 src/util/glibcompat.h >

> +/* Due to a bug in glib, g_strdup_printf() nor g_strdup_vprintf() > + * abort on OOM. It's fixed in glib's upstream. Provide our own > + * implementation until the fix get's distributed. */ > +char * > +vir_g_strdup_printf(const char *msg, ...) > +{ > + va_list args; > + char *ret; > + va_start(args, msg); > + ret = g_strdup_vprintf(msg, args); > + if (!ret) > + abort(); > + va_end(args); > + return ret; > +} > + > + > +char * > +vir_g_strdup_vprintf(const char *msg, va_list args) > +{ > + char *ret; > + ret = g_strdup_vprintf(msg, args); So this will become vir_g_strdup_vprintf.. thus become infinite recursion.