On Tue, Apr 13, 2010 at 02:36:45PM -0400, Chris Lalancette wrote:
Hello, As we discussed on the list, here are RFC patches that allow both qemu monitor passthrough and the ability to specify extra arguments to be passed on the qemu command-line. I've specifically not done the more complicated regex command-line editing for now, since we don't have consensus on it. There are a few outstanding issues with these patches:
1) Should we have a separate structure for the per-driver qemuMonitorCommand entry point?
Or just not use driver tables at all for specific code. Declare the function entry points in qemu_driver.h and make the libvirt_qemu.c file directly reference it
2) Due to the way that virsh parses command-line arguments, it's not possible to pass it an argument that has spaces (even if you properly quote it). Therefore I have a hack in place that will convert ^ to space before passing it along, which is pretty crappy. How should we go about fixing this? Fix virsh argument parsing, or go about it a different way?
Sounds like fixing virsh is better - I could well imagine that other commands could benefit from being able to use quoted strings with embedded whitespace Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|